search

mbi / django-rosetta

Rosetta is a Django application that eases the translation process of your Django projects
MIT License
1.08k stars 195 forks source link

'Last-Translator' is written as b'....' in pofile #259

Closed NotSqrt closed 3 years ago

NotSqrt commented 3 years ago

Hello,

(Using python3.6, django 1.11, latest polib, django-rosetta==0.9.4)

There's a .encode('ascii', 'ignore') that is used when preparing the value for Last-Translator here: https://github.com/mbi/django-rosetta/blob/417094f0f19de1e392adf9ea1a7471d5914d8c3c/rosetta/views.py#L378

Which makes the translator appear as follows in my po files:

"Last-Translator: b'FirstName LastName <email@domain.ltd>'\n"

I guess that now that you only support python3, this string should be a str and not bytes.

Thanks !