mbi / django-rosetta

Rosetta is a Django application that eases the translation process of your Django projects
MIT License
1.07k stars 195 forks source link

Loop DeepL suggestions through the backend #270

Closed matthiask closed 1 year ago

matthiask commented 2 years ago

DeepL wants an Authorization header but we cannot set this in the JavaScript code because of missing CORS headers on the DeepL side.

Opening as a draft pull request because this change introduces a different way to fetch suggestions from third party services.

All Submissions:

matthiask commented 2 years ago

Ah... I see that Google and Azure are handled the same way already. Let me clean this up.

mbi commented 1 year ago

Hello and thank you so much for your PR. I just noticed it, right after pushing my own correction for #271, sorry about that. :facepalm:

Maybe you'd like to take a look at my implementation, and if if you notice anything worth improving, please do not hesitate!

matthiask commented 1 year ago

Thanks for the fix! LGTM.