easy-to-fix bug in 'mask_and_norm_backward_actions' function

mbi2gs / gflownet_tf2

Generative Flow Network demo in Tensorflow2

MIT License

8 stars 5 forks source link

easy-to-fix bug in 'mask_and_norm_backward_actions' function #1

Closed kzk2000 closed 2 years ago

kzk2000 commented 2 years ago

Digging through your (awesome) code, I believe I discovered a bug in your backwards masking, the mask defined in line 176 is not applied in line 177 (in fact it's not used at all)

https://github.com/mbi2gs/gflownet_tf2/blob/aece0a5463dc0df4d1773bebdb136efbb35fe317/gfn.py#L176

hope this helps

mbi2gs commented 2 years ago

Good catch! I just pushed the update.