Various adjustments - Githubissues

mbideau / vcardtools

Automatically fix, split, normalize, group and merge/deduplicate vCard and VCF files (even large ones).

GNU General Public License v3.0

46 stars 9 forks source link

Various adjustments #15

Open chrysn opened 2 years ago

chrysn commented 2 years ago

I've used this tool in a larger address book merging operation, thanks for providing it.

I had to make a few adjustments for it to work well on my use case -- none of which are ship-shape right now, but I though this would just as well work as one draft PR than a bunch of single wishlist issues.

What's in here varies by degree of reusability -- is there anything you'd deem generally useful?

Preserving file names (hard-coded right now, this would need some conditional) -- this was useful for me because I could then move the files back onto the originals and do a git diff on them
setting PRODID and REV -- useful as a first normalization step, before at merging they'd always show up as changes (so if I change things once, commit that, and then do the merging, the merging doesn't show artifacts of the tool change. The REV would probably need to be passed in, not sure how that's best done).
I'm kicking out a few actually useless X- values ... might this be useful in a generalized "remove any attribute in this list" form?

chrysn commented 2 years ago

If I'd ever need this again, I'd probably also make sure that CATEGORY items are merged -- given that Evolution ignores the second occurrence.

mbideau commented 2 years ago

Hi @chrysn,

First, sorry for the delay of my answer... I'm pretty busy IRL doing construction in my apartment and other stuff...

Glad that this piece of code was useful to somebody else :wink:

Thank you very much for all your feedback/contributions, which I found great :+1: Really appreciated :pray:

I would add an option to let the user choose between: keeping the original vcard filename and renaming it to the selected (hopefully best) name. Could you implement that ? Also it breaks the tests cases, so if you could just duplicates them, and rename the "expected" files. If you need help don't hesitate to ask me, even if I can't reply as quickly as I would like.

About the merging of the CATEGORY item, please feel free to implement it, I would happily merge it, like I will merge all your other features in this branch.

Keep up the good work.

And thanks again ! Waiting for your feedback...

mbideau commented 1 year ago

Hi @chrysn , How are you ? Do you think you will eventually give another feedback and make some progress on this PR or should I make it my own and implements myself the feedback I have written to you ? It is perfectly OK to have no time/nor more interest for this :wink: Thank again for your contributions. Best regards,