Change the "Envelope modulates frequency" settings into sliders.

mbitsnbites / soundbox

SoundBox is an HTML5 synth music tracker/editor, suitable for creating music for small JavaScript demos (4K / 8K).

https://gitlab.com/mbitsnbites/soundbox

429 stars 77 forks source link

Change the "Envelope modulates frequency" settings into sliders. #72

Closed vsariola closed 3 years ago

vsariola commented 4 years ago

Implements #70

esaruoho commented 4 years ago

@mbitsnbites any thoughts on this PR? :)

mbitsnbites commented 4 years ago

Sorry for taking so long. Will have a look ASAP.

mbitsnbites commented 4 years ago

Apart from the comments, this LGTM.

vsariola commented 4 years ago

Ok, since we went with larger than /8, I went directly to /32, because that makes no difference in uncompressed song size, but allows even smaller exponents, which produces just a bit of natural sounding touch to instruments. I also kept Math.pow in everywhere else than player-small, where I used the exponentiation operator and left a comment to use Math.pow if needed by browser.

Also, I rebased to master.