search

mbj / devtools

The rake ci task!
MIT License
64 stars 20 forks source link

Update rubocop and reek #126

Closed backus closed 8 years ago

backus commented 8 years ago

Thoughts on this branch name? I've opened about 10 dependency update PRs so far and it usually isn't obvious how to name them uniquely. I think adopting something like update/dependencies/march-2016 might be nice

dkubb commented 8 years ago

Thoughts on this branch name?

For dependency upgrades I usually just use something like fix/upgrade-deps. They aren't open for very long, and I don't know if there's a lot of value in naming it something more specific.

mbj commented 8 years ago

For dependency upgrades I usually just use something like fix/upgrade-deps. They aren't open for very long, and I don't know if there's a lot of value in naming it something more specific.

Yeah, branch names are empheral as they are not part of the git repositories history. Github keeps them as metadata, but given the fact we could leave github any time its not worth inflating the amount of information in a piece of data that will not be useful in the future.

All I care about is what happens to the master branch.

Merging anyway, because as I said: the branch name is not as important. Lets go with fix/... as we used in the past.