Closed barthez closed 7 years ago
@barthez Thx. Code wise I'm fine with this. Will merge on green. @backus When you see this green earlier than me and agree feel free to merge also.
Mhh, circle CI integration appears to be dead.
@mbj It seems we are having troubles with Flay:
Flay total is now 115, but expected 112
I'm not familiar with Flay at all, can I just increase total_score
to 115?
I'm not familiar with Flay at all, can I just increase total_score to 115?
Yes. This change is within the acceptable standard derivation.
@barthez Do you mind to squash all these together? This way we have one atomic good change, rater than 3 changes that first put the repo in a bad state that with the last commit is resolved.
@mbj Done 👍
@barthez Released as 0.1.18
.
I'm trying to update Unparser gem to support Ruby 2.4, but there is a complicated chain of dependencies.
I will try to update devtools and mutant, so I can make Unparser depend on Parser 2.4 and support new language features (I believe there is only one: multiple assignments in if statement).
We need to update SimpleCov - because 0.12.0 was using Fixnum as well, reek 4.5 depends on parser v2.3.0.