search

mbj / devtools

The rake ci task!
MIT License
64 stars 20 forks source link

Update reek to 3.3.1 #80

Closed backus closed 9 years ago

backus commented 9 years ago

Following up on #79, this bumps reek to the latest release (reek v3.3.1) which shouldn't break the build

mbj commented 9 years ago

I need to revert this as AST processing breaks on some input in morpher:

mbj@mbj ~/devel/ruby/morpher (fix/upgrade-anima) % bundle exec rake metrics:reek
/home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/ast/sexp_extensions.rb:435:in `defines_module?': undefined method `simple_name' for nil:NilClass (NoMethodError)
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:60:in `process_casgn'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:44:in `process'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:83:in `block in process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `each'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:53:in `block in process_module'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:201:in `block in inside_new_context'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:214:in `push'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:200:in `inside_new_context'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:52:in `process_module'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:44:in `process'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:83:in `block in process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `each'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:139:in `process_begin'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:44:in `process'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:83:in `block in process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `each'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:53:in `block in process_module'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:201:in `block in inside_new_context'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:214:in `push'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:200:in `inside_new_context'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:52:in `process_module'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:44:in `process'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:83:in `block in process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `each'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:53:in `block in process_module'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:201:in `block in inside_new_context'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:214:in `push'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:200:in `inside_new_context'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:52:in `process_module'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:44:in `process'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:83:in `block in process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `each'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:82:in `process_default'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:139:in `process_begin'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:44:in `process'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:38:in `result'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/tree_walker.rb:27:in `walk'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/examiner.rb:77:in `run'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/examiner.rb:37:in `initialize'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/cli/reek_command.rb:14:in `new'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/cli/reek_command.rb:14:in `block in execute'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/cli/reek_command.rb:13:in `each'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/cli/reek_command.rb:13:in `execute'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/lib/reek/cli/application.rb:34:in `execute'
        from /home/mbj/.gem/ruby/2.2.3/gems/reek-3.3.1/bin/reek:12:in `<top (required)>'
        from /home/mbj/.gem/ruby/2.2.3/bin/reek:23:in `load'
        from /home/mbj/.gem/ruby/2.2.3/bin/reek:23:in `<main>'

!!! `reek` has found smells - exiting!