Closed backus closed 9 years ago
@mbj @dkubb this should be ready for review. Mainly just a refactor of flay handling + test coverage for flay. Last commit adds in the ability to filter out files
@backus Is this ready for review?
@mbj yes the flags you noted have been fixed. I'm just working on mutation coverage.
— Sent from Mailbox
On Fri, Oct 9, 2015 at 5:35 AM, Markus Schirp notifications@github.com wrote:
@backus Is this ready for review?
Reply to this email directly or view it on GitHub: https://github.com/mbj/devtools/pull/91#issuecomment-146854618
@mbj yes the flags you noted have been fixed. I'm just working on mutation coverage.
Lets add a commit that does --since
in front of all yours. This would show the status of mutation coverage to the builds.
I did. If you look at the commits it should be in the middle. I added it as the most recent commit and I've been moving in back in Git history as I resolve mutations in recent commits
— Sent from Mailbox
On Fri, Oct 9, 2015 at 7:50 AM, Markus Schirp notifications@github.com wrote:
@mbj yes the flags you noted have been fixed. I'm just working on mutation coverage.
Lets add a commit that does
--since
in front of all yours. This would show the status of mutation coverage to the builds.Reply to this email directly or view it on GitHub: https://github.com/mbj/devtools/pull/91#issuecomment-146893667
@mbj The commit enabling mutant with --since
is now in front of the other commits (see 69af5b4). I squashed down a few commits and now every commit passes with mutant enabled
@backus I finished a code only pass. Most of my flags are stylistic and not semantic, only the namespace reopening one is semantically relevant.
@mbj should be ready for another pass
@backus thx.
I'd like to add the option to exclude files from the flay task. I need to do some work first to extract the flay task from the original rake task.
https://github.com/backus/devtools/commit/aad3d8d4f868c705b00624170c712d653ae5901e essentially extracts the task body into a single method so that I can work in bringing up test coverage before refactoring it.