Dubious Mutation: super(*arguments) -> super

[postmodern]

Alive: rspec:Ronin::SQL::Fields#method_missing:/vault/1/code/ronin/ronin-sql/lib/ronin/sql/fields.rb:55:1ff3e (2.24s)
@@ -2,7 +2,7 @@
   if ((arguments.empty?) && (block.nil?))
     Field.new(name)
   else
-    super(name, *arguments, &block)
+    super
   end
 end

[mbj]

Why this is not a valid mutation?

[postmodern]

super without arguments implicitly passes all arguments.

[mbj]

I know. It is a Rubinius::AST::ZSuper node with differend bytecode and behavior. So again why this is not a valid mutation?

[postmodern]

Doesn't change behaviour, mutant doesn't get killed.

[mbj]

So you explicit argument passing is just the same as using the zsuper node. You should refactor your code to use the zsuper to kill it.

A good strategy is to change the code to the mutation, and try to create a spec that forces you to switch back. If you cannot find such a spec, just accept the code ;).

[postmodern]

Ah good point. Let me try.

[mbj]

Heh, using this strategy, can I convince you to omit unneeded explicit returns also? ;)

[postmodern]

Sorry, having a local variable dangling at the end of a method looks weird (to me).

[mbj]

Was a try ;)

On Mon, Jan 21, 2013 at 12:58:03AM -0800, Postmodern wrote:

Sorry, having a local variable dangling at the end of a method looks weird.

---

Reply to this email directly or view it on GitHub: https://github.com/mbj/mutant/issues/15#issuecomment-12489124

Markus Schirp

Phone: +49 201 / 360 379 14 Fax: +49 201 / 360 379 16 Web: www.seonic.net Email: mbj@seonic.net Twitter: twitter.com/_m_bj OS-Code: github.com/mbj

Seonic IT-Systems GbR Anton Shatalov & Markus Schirp Altendorferstrasse 44 D-45127 Essen

[mbj]

@postmodern Can we close this issue?

[mbj]

Thx.