search

mbj / stratosphere

Haskell EDSL and type-checker for AWS CloudFormation templates
MIT License
162 stars 19 forks source link

Change import value intrinsic functions to allow computed values #155

Closed mbj closed 4 years ago

mbj commented 4 years ago

See: https://docs.aws.amazon.com/AWSCloudFormation/latest/UserGuide/intrinsic-function-reference-importvalue.html

TLDR: The argument to Fn::ImportValue allows expressions evaluating to Text.

jdreaver commented 4 years ago

Wow, I wonder if this was changed since I first added ImportValue, or if I'm silly and just missed it the first time :sweat_smile:

Thanks!

jdreaver commented 4 years ago

I'll upload a new version to Hackage tonight or early tomorrow, assuming CI passes on master.

mbj commented 4 years ago

Wow, I wonder if this was changed since I first added ImportValue, or if I'm silly and just missed it the first time

I was using it on plain YAML for years now. I suspect it was missed. But I do not think that missing it qualifies for the attribute silly. Thanks for the quick merge + pending release.

If you can release tonight it spares me from using my fork, I'm about to crash for the day.

jdreaver commented 4 years ago

I just released stratosphere-0.49.0 with this change included :+1: Thanks again!