search

mbj4668 / pyang

An extensible YANG validator and converter in python
ISC License
530 stars 342 forks source link

bugfix: test_feature make test failed and remove make clean #829

Closed fredgan closed 1 year ago

fredgan commented 1 year ago

  1. In test/test_feature directory, the *.expect files are needed for diff, but make clean will delete them. So I remove the make clean in Makefile

  2. Output are not symmetrical, I adjust a bit in feature.py and the expect files.

  3. include-exclude-different failed, I modify the expect file.

Please have a look at this. Thanks @wlupton

wlupton commented 1 year ago

I agree with the Makefile change, and with fixing include-exclude-different.expect (this may have been an oversight in 1380919?).

I don't really see the need for the feature.py change (actually @mbj4668 has touched this more recently than me) but it's not a big deal.

fredgan commented 1 year ago

OK, I revert the second change.