mbj4668 / pyang

An extensible YANG validator and converter in python
ISC License
528 stars 342 forks source link

UML Plugin: Fix incorrect error message when using UML option --uml-no=identity #900

Open nkhancock opened 2 months ago

nkhancock commented 2 months ago

When using the UML option --uml-no=identity as listed as available in the help for UML options, pyang issues the following error message, but correctly renders the UML without identities as expected.

"identity" no valid argument to --uml-no=..., valid arguments: ('module', 'leafref', 'uses', 'annotation', 'identityref', 'typedef', 'import', 'circles', 'stereotypes', 'prefix', 'footer', 'title')

This error message is issued becaused the keyword "identity" is not included in the tuple 'nostrings', against which the UML plugin checks the validity of the uml-no arguments.

This fix adds the string "identity" to 'nostrings'. It also reorders the strings (has no effect) to align with the order listed in the help information for easier comparison.

This fix was verified using the module bbf-hardware-types, which contains only feature and identity statements.