Check that the R?Spec::Matchers namespace exists, not just its parent.

mbklein / equivalent-xml

Easy equivalency tests for Nokogiri and Oga XML

MIT License

94 stars 29 forks source link

Check that the R?Spec::Matchers namespace exists, not just its parent. #14

Closed elandesign closed 10 years ago

elandesign commented 10 years ago

Cucumber defines a Spec::Runner module but not a Spec::Matchers module, which causes

uninitialized constant Spec::Matchers (NameError)

I see this was raised and acknowledged in https://github.com/mbklein/equivalent-xml/pull/5, but not merged. Had a quick check and defined?(::Foo::Bar) doesn't cause an exception here (on 1.9.3 at least) so I think this should be good to merge.

mbklein commented 10 years ago

While I understand the issue, this approach seems to make all the tests fail. I'll look into it if I have time, but that may be a while. I can't merge it in its current state.

elandesign commented 10 years ago

Oops, sorry about that - forgot to update equivalent-xml_spec.rb. Tests now pass.