search

mbklein / equivalent-xml

Easy equivalency tests for Nokogiri and Oga XML
MIT License
94 stars 29 forks source link

Update library to fix/remove Ruby warnings #26

Closed nbibler closed 9 years ago

nbibler commented 10 years ago

Currently, equivalent-xml creates two sets of Ruby warnings: a circular dependency between equivalent-xml.rb and the RSpec matchers, and an ampersand usage assumption.

This pull request does not change any of the existing functionality, it simply corrects the code which generates the warnings.

nbibler commented 10 years ago

The build failure appears to be due to the bug in the recent RSpec v3.1.0 release where Arrays could not be passed into the RSpec pattern. That bug/regression was since fixed in v3.1.1.

I'll attempt to get Travis to re-run the previous build. It should now pass.

nbibler commented 10 years ago

Since I couldn't manually trigger a re-run of the pull request build, I instead just fixed the RSpec problem and added it to this pull request. ;)