search

mbknor / mbknor-jackson-jsonSchema

Generate JSON Schema with Polymorphism using Jackson annotations
MIT License
232 stars 75 forks source link

Rewrite in Java, drop Scala dependencies #159

Open almson opened 2 years ago

almson commented 2 years ago

Resolves #160 Tests pass. This has the same behavior as 1.0.39, with fix to #152.

Most of the changes are straight conversions from Scala to Java. Use of Option and endless map and foreach has been eliminated in favor of simple if(... != null). A few things were refactored such as moved into separate files, but not much. The Java code actually ended up being more concise and definitely a lot clearer than Scala.

EDIT: I realized I should have made a separate branch with original groupId, etc. If there's interest, I'll recreate this PR.

muliyul commented 2 years ago

Please consider this PR seriously. The Scala collection dependencies really hurt.

kyale commented 4 months ago

Why is nobody merging this?