mblackgeo / flask-cognito-lib

A Flask extension that supports protecting routes with AWS Cognito following OAuth 2.1 best practices
https://mblackgeo.github.io/flask-cognito-lib/
MIT License
59 stars 18 forks source link

Save cognito_id_token in cookie #45

Closed Ulthran closed 2 months ago

Ulthran commented 4 months ago

Not sure if these changes are within the scope of the package as you see it, but I had to spend a while learning about Cognito and the many ways of authenticating to AWS services so figured I'd include this to make it easier on the next.

FYI, my use case is an AWS Amplify app that I then want to have a separate flask site with access to all the components. Not sure if that should be mentioned in the docs or not.

mblackgeo commented 3 months ago

Hey apologies for the delay in getting round to this - are you able to separate out the functional changes from documentation into separate PRs please?

planestoner commented 3 months ago

Hi, is there any progress on this PR as it would be very beneficial and appears similar to that which was reported in issue #37? If I'd be willing to submit the PRs but would you be able to clarify the request

separate out the functional changes from documentation into separate PRs please?

Are you requesting the a PR for the changes to config.py and decorators.py in one PR and then the docs/accessing-aws-resources.md in a separate PR?

Ulthran commented 2 months ago

Done with #50!

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 100.00%. Comparing base (08a679b) to head (81b0442). Report is 2 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #45 +/- ## ========================================= Coverage 100.00% 100.00% ========================================= Files 9 9 Lines 400 407 +7 ========================================= + Hits 400 407 +7 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

mblackgeo commented 2 months ago

Thanks for the contribution - now release in v1.9.0 :tada: