Closed juansaavedrauy closed 7 years ago
I will look at the comments and submit the changes. They all look good. Would you let me know if I should change something in the TravisCI file for the checks to work?
I'm going to be either busy or on a flight between now and Saturday, and may not be able to dive back in until Monday (thanks to jet lag and reuniting with friends after a month in Europe), so apologies in advance for that.
Also due to my work and travel schedule, I still haven't had a chance to look into what's going on with Travis, so feel free to experiment if you like! If not, no worries; I'll take a look as soon as I can.
Hey, sorry it's been a while...finally got some time to dig into the failure. When SimonKagstrom/kcov#211 gets merged, I'll kick off a new build and review.
I've updated the code as you suggested. In the end, I could not use process substitution for the tar
command. Nevertheless, I've managed to use pipefail
and restore it afterwards.
I still believe that it looks a bit clumsy, so feel free to come back with more changes and corrections.
Thanks.
Wow, I can't believe how long I've let this sit... Apologies.
I've pulled your branch locally and am looking at it right now. I'm anticipating I'll end up merging your branch, then I'll create a new PR to push a commit with minor tweaks, and then release v1.6.0 so it's officially available.
FWIW, I've been heads-down on other projects (devs-setup and custom-links), and have come up with some more stuff I want to push into v1.7.0 soon. One of the most fun things is more Bats helpers to test server or other processes that need to run in the background for a bit.
It drops git clone as a mean of getting a release for
go-script-bash
in favor of a download of the release file from github through curl.It uses
tar
to extract the downloaded file. Tested in bsdtar and gnutar.Please review the error handling for the pipe, I'm not prolific in bash scripting and I found it to be a non robust checking.