Download release file instead of cloning repo in go-template (continued from #179) - Githubissues

mbland / go-script-bash

Framework for writing modular, discoverable, testable Bash scripts

ISC License

95 stars 16 forks source link

Download release file instead of cloning repo in go-template (continued from #179) #180

Closed mbland closed 7 years ago

mbland commented 7 years ago

Closes #179.

I've taken @elpaquete's fine work from #179 and refactored it a bit to:

rebase on master (after I remembered to push the v1.5.0 commit just today—d'oh!)
fix a few bugs
add a few tests
clean up the formatting
restore the ability to test it without a network connection
add the capability to use wget and fetch as well.

I still need to test this on all the platforms (I think I might need to add tweaks for MSYS2), but I hope to have it in by tomorrow and cut v1.6.0 right away.

@elpaquete Note that I found a way to get rid of curl | tar and set -o pipefail, namely by using a command substitution and checking that the expected output is present.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling 57e7356ab81a776450e4b600061755522bbcabfe on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling 238fcdabccc5fca95f8f0639509ca81a15168933 on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling 0784a04a4f9d4588685cf9fc265b4c86e9c30179 on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling d27dc1263d8397730841eb7d2d3fa9fd8cf3c033 on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling 2f6aeca1f1af326e31fa0973e086aae2552b4f67 on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling f4f5fd7b5c6c3504173b3c927c403b4b48a110e3 on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling 757cf46c8d251f0034925157eaff25c783f6b5ad on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling fc55a10504fc6215a9ad55f71565aa78fb22e96a on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

coveralls commented 7 years ago

Coverage decreased (-0.02%) to 94.605% when pulling 96af8f47e258be5cffa8300cda4b9fad24701a68 on go-template-download into 779f544da5acb2ddb2d79fc610569d88172b3578 on master.

mbland commented 7 years ago

Wow, it literally took me all day to get things smoothed out across platforms. Specifically, I came to realize how particular the Git for Windows environment is, even compared to plain MSYS2 and Cygwin. But now I'm armed with insight from that experience (including my discovery of the cygpath utility), and all the tests pass everywhere.

Thanks for the contribution, @elpaquete! Though since it's almost 9pm and I haven't had dinner yet, I think I'll cut v1.6.0 tomorrow. 🙂