search

mbland / slack-emoji-issues

Library for using Slack reaction_added events to file GitHub issues
https://www.npmjs.com/package/slack-github-issues
ISC License
4 stars 3 forks source link

Add Robot.react to Hubot >= v3.0.0 #16

Closed mbland closed 7 years ago

mbland commented 7 years ago

Addresses the issue described in #15. In short, hubot-test-helper v1.8.0 depends on hubot-v3.0.0, both are rewrites from CoffeeScript to ES2015, and consequently hubot-slack adds Robot.react to a CoffeeScript-compatible wrapper function, leading to smoke and integration test failures.

The implementation of slackapi/hubot-slack#429 (CoffeeScript-to-ES2015 rewrite) should include a fix that will eliminate the need for this workaround.

Also adds a callback to fix the DeprecationWarning that Node.js started emitting from tests/integration-test.js:

(node:85642) [DEP0013] DeprecationWarning: Calling an asynchronous
  function without callback is deprecated.

By following the process event warning instructions in the Node.js API docs, I was able to emit the stack trace pinpointing the fs.write call as the offender.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a84ca77c6fe1a1d5bf32d410e1f533aecc066fa7 on es2015-fix into on master.

coveralls commented 7 years ago

Coverage Status

Changes Unknown when pulling a84ca77c6fe1a1d5bf32d410e1f533aecc066fa7 on es2015-fix into on master.