search

mbland / slack-emoji-issues

Library for using Slack reaction_added events to file GitHub issues
https://www.npmjs.com/package/slack-github-issues
ISC License
4 stars 3 forks source link

filer: Ignore reactions to files, file comments #6

Closed mbland closed 7 years ago

mbland commented 7 years ago

This was causing errors to appear in the logs since reactions were getting added to other objects:

  [Wed Apr 19 2017 08:59:53 GMT+0200 (CEST)] ERROR TypeError: Cannot read property '0' of undefined
    at ReactionIssueFiler.execute (.../node_modules/slack-github-issues/lib/reaction-issue-filer.js:30:27)

In the future, we may want to support file and file comment reactions, but it's not straightforward, since there's no one specific channel or timestamp associated with either.

cc @kenock @mgwalker

coveralls commented 7 years ago

Coverage Status

Coverage remained the same at 98.646% when pulling 00dcb4fe3a374bc27e768bb63da11bbcb59cfe09 on ignore-reactions into 980d97c0f232a4774ef5e56b302c2a827bae4978 on master.