search

mblayman / markwiki

:warning: UNMAINTAINED: A simple wiki using Markdown
BSD 2-Clause "Simplified" License
29 stars 14 forks source link

Update engine.py #22

Closed kurobeats closed 9 years ago

kurobeats commented 9 years ago

Updated content=unicode(content) to content=str(content) to be python3 compliant

mblayman commented 9 years ago

@Oweoqi Thanks for the PR. As you may see from the Travis results, this breaks MarkWiki for Python 2. The trouble is that Whoosh relies on Unicode and str does not mean Unicode in Python 2.

If anything, I'd like to support both Python 2 and 3. I've been focusing my time on other projects, but I may be able to devote some time to making MarkWiki Python 3 compatible.

mblayman commented 9 years ago

The fix for unicode is quite a bit more involved than the small change in this branch. I've got another branch (see PR #23) where I'm adding Python 3 support. Thanks for the motivation to get this ported. I'll probably put out a release after that is merged. I'm going to close out this PR.