search

mbleigh / acts-as-taggable-on

A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.
http://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on
MIT License
4.96k stars 1.2k forks source link

DEPRECATION WARNING: last argument as keyword parameters is deprecated #1003

Closed francesco-loreti closed 3 years ago

francesco-loreti commented 4 years ago

acts-as-taggable-on 6.5.0 rails Rails 6.0.3.1 Ruby 2.7.1

Running specs that involve tags results in this deprecation notice: acts-as-taggable-on-6.5.0/lib/acts_as_taggable_on/tagging.rb:9: warning: Using the last argument as keyword parameters is deprecated; maybe ** should be added to the call

brchristian commented 4 years ago

We are having this issue as well. Looks to me like https://github.com/mbleigh/acts-as-taggable-on/pull/999 fixed this, but it hasn’t made it into a rubygems release.

@mbleigh, any chance we could get a 6.5.1 that includes https://github.com/mbleigh/acts-as-taggable-on/pull/999 in it?

stanhu commented 4 years ago

@mbleigh Would you mind tagging a new release here for Ruby 2.7?

silva96 commented 4 years ago

looking forward for this update too.

igor-drozdov commented 4 years ago

@seuros could you please have a look as well?

ErCollao commented 3 years ago

+1 to this, and thanks for making a great gem!

spikeheap commented 3 years ago

We're coming up against this issue as well. I'd normally not "+1" issues, but it looks about time for a monthly poke to resurface it.

Are there any plans for a release? Is this module still maintained? It looks like changes have made it into the main branch, but there's not been a release in 12 months.

ruurd commented 3 years ago

+1 as well

seuros commented 3 years ago

7.0.0 was released

silva96 commented 3 years ago

👏 @seuros !

ruurd commented 3 years ago

Thank you @seuros and everybody!