mbleigh / acts-as-taggable-on

A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.
http://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on
MIT License
4.97k stars 1.2k forks source link

Arel.sql warning when using owned tags. #1006

Closed jhirn closed 3 years ago

jhirn commented 4 years ago

Using the folowing line of code: organization.tag(self, with: csv_list_for_taggable_gem, on: :positions)

I get the following deprecation warning.

DEPRECATION WARNING: Dangerous query method (method whose arguments are used as raw SQL) called with 
non-attribute argument(s): "public.taggings.id". Non-attribute arguments will be disallowed in Rails 6.0. 
This method should not be called with user-provided values, such as request parameters or model attributes. 
Known-safe values can be passed by wrapping them in Arel.sql(). (called from block (6 levels) in <main> at 
seuros commented 3 years ago

fixed in 7.0