search

mbleigh / acts-as-taggable-on

A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.
http://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on
MIT License
4.96k stars 1.2k forks source link

Add Rails 6.1 support #1013

Closed kvokka closed 3 years ago

kvokka commented 3 years ago

By the way switch from using rails6.0.beta1 to released version in CI

cantino commented 3 years ago

Yes please!

silva96 commented 3 years ago

why there are 3 pr for rails 6.1 support?

kvokka commented 3 years ago

@silva96 at the moment of this branch creation, PR #1012 was not actually using rails 6.1 gemfiles and in fact it was not working, unfortunately, that pushed me to create this PR

idk why #1015 was created, can only say, that it will not work correctly (you will see it in CI, which by the way runs forever). It has a few issues, which are fixed in this PR.

silva96 commented 3 years ago

@kvokka thanks for the explanation

silva96 commented 3 years ago

@mbleigh do you mind take a look here?

mbleigh commented 3 years ago

Sorry, I haven't been the maintainer of this library for 5+ years 😅 I'm actually not even sure who is the primary maintainer these days.

mkilling commented 3 years ago

@seuros do you by any chance know who currently maintains this repo?

seuros commented 3 years ago

@mkilling , Sorry i missed this PR. I will check it and release a new version.

seuros commented 3 years ago

If there is no regression in master, this will be released by end of week. I don't see any warning.

mrbongiolo commented 3 years ago

Thank you @seuros !!

silva96 commented 3 years ago

Merry christmas! @seuros any update with the release?