mbleigh / acts-as-taggable-on

A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.
http://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on
MIT License
4.97k stars 1.2k forks source link

fix #1036 scope taggable#tenant method name to #taggable_tenant #1037

Closed ngouy closed 3 years ago

ngouy commented 3 years ago

If your taggable model already have a #tenant attribute/method/relationship, it would broke your code.

A small modification is required to scope this (non-documented and normally non directly used) method to the taggable lexical scope to fix the issue

ngouy commented 3 years ago

tested on a real project with already existing tenants and it works (I pass from a broken app to a working app)

seuros commented 3 years ago

Can you bump version 8.1 and update the Changelog ?

ngouy commented 3 years ago

@seuros can we also address the #read_attribute issue before please ? really need that on my hand

If we have no specific reason for it's usage I can just use #public_send instead

seuros commented 3 years ago

Sure thing

ngouy commented 3 years ago

@seuros we should be good, minor version bump and changelog updated included

seuros commented 3 years ago

Awesome work

ngouy commented 3 years ago

@seuros when do you think will you release it (no pressure just wondering in terms of planning)

seuros commented 3 years ago

Tomorrow max