search

mbleigh / acts-as-taggable-on

A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.
http://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on
MIT License
4.98k stars 1.19k forks source link

matches_attribute was not being used in tag_match_type #871

Closed tekniklr closed 6 years ago

tekniklr commented 6 years ago

addresses https://github.com/mbleigh/acts-as-taggable-on/issues/869

botandrose commented 6 years ago

I ran into #869 on upgrading to 5.0.0, and can confirm this patch fixed it for me, as well. Suggest merging, and releasing a 5.0.1?

idoo commented 6 years ago

it also works well for me! thanks @tekniklr probably we need some specs for that case

@mbleigh what we can do to get it merged?