search

mbleigh / acts-as-taggable-on

A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.
http://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on
MIT License
4.98k stars 1.19k forks source link

improve postgres escape sequence #882

Closed rsl closed 6 years ago

rsl commented 6 years ago

Fixes https://github.com/mbleigh/acts-as-taggable-on/issues/864

I'm not sure why ActsAsTaggableOn::Utils#escape_like is named specifically for like when it seems to be generic escape functionality. wondering if this should be renamed to just escape?

Also, unsure about add myself to CHANGELOG.md and documenting this change since all the entries seem to be tied to a gem version. Is this no longer the practice? Could not see this in other recent PR as well.

Thanks and sorry for all the questions heh.

lunaru commented 6 years ago

👍 Looks great! Would love to see this get merged in. Build is failing for the same reason as already addressed in this PR https://github.com/mbleigh/acts-as-taggable-on/pull/880

rsl commented 6 years ago

thanks

rsl commented 6 years ago

@seuros hi. this got rolled back because it was breaking build. it passes for me locally. is there a way to run it through the same CI as the main repo?

seuros commented 6 years ago

Of course, if you open a PR, Travis will run on it.

rsl commented 6 years ago

hrm. i guess i didn't see any breakage. i would have thought it reported that in the PR.

rsl commented 6 years ago

i'm looking to correct them if possible

rsl commented 6 years ago

managed to find the travis build for this PR! https://travis-ci.org/mbleigh/acts-as-taggable-on/jobs/339031800

it looks like there's a configuration issue? https://travis-ci.org/mbleigh/acts-as-taggable-on/jobs/339031800#L657