search

mbleigh / acts-as-taggable-on

A tagging plugin for Rails applications that allows for custom tagging along dynamic contexts.
http://mbleigh.lighthouseapp.com/projects/10116-acts-as-taggable-on
MIT License
4.96k stars 1.2k forks source link

Do not apply binary collation every time on rails boot for MySQL users #977

Open shawnali63 opened 4 years ago

shawnali63 commented 4 years ago

Fixes #905

Background: To fix collation issue with MySQL we added ActsAsTaggableOn.force_binary_collation = true

Reason: With force_binary_collation = true option we execute following script every time on rails boot which is trying to update database which is not yet available. 

ActiveRecord::Migration.execute("ALTER TABLE tags MODIFY name varchar(255) CHARACTER SET utf8 COLLATE utf8_bin;")

This script should be executed only once not every time when rails is booted. User must set collation by re-running migration generator or run this rake task:

rake acts_as_taggable_on_engine:tag_names:collate_bin

matthewhively commented 3 years ago

I wish this would get merged, the ALTER TABLE statements executed every boot is anoying.

skaidra-bake commented 3 years ago

Hey guys, is there an ETA for when this would get merged in? thanks