search

mbleron / ExcelTable

ExcelTable is an Oracle SQL interface to read Microsoft Excel files (.xlsx, .xlsm, .xlsb, .xls, .xml), ODF spreadsheet files (.ods) and flat files as external tables
MIT License
45 stars 12 forks source link

Verify that Java Classes have been installed #30

Closed gpaulissen closed 3 years ago

gpaulissen commented 3 years ago

The read method ExcelTable.DOM_READ is available by default but other methods may depend on the Java classes being installed. In the Oracle Cloud, Java is not even supported so for the calling program it may be usefull to verify which read method is available in order to prevent run-time errors due to the fact that the Java classes are not installed.

In addition to this Java check, it appeared that the getSheets function did not work well when Java was not installed. So conform the other functions the read method was added as a parameter (which defaults to ExcelTable.DOM_READ).

Therefore the following changes have been proposed:

gpaulissen commented 3 years ago

As far as I am concerned I think everything is okay.