mblode / marx

The classless CSS reset (perfect for Communists).
https://mblode.github.io/marx/
MIT License
1.69k stars 101 forks source link

Sanitize 3.3.0 -> ^5.0.0 and more #32

Closed inoas closed 6 years ago

inoas commented 6 years ago

Changelist

Notes

While the HTML 5 Test Page renders just fine due to the update of Sanitize 3.3.0 to ^5.0.0 I'd consider setting this up as Marx 4.0.0.

Questions

Any chance this can get merged and tagged as a release @mblode


Resolves https://github.com/mblode/marx/issues/31

inoas commented 6 years ago

Note @mblode: In case this gets merged https://codepen.io/mblode/details/JdYbJj will require an update

mblode commented 6 years ago

You're an absolute legend for keeping this project updated! Will make a release very shortly!! 👍

inoas commented 6 years ago

@mblode two things: a.) please don't forget to update https://codepen.io/mblode/details/JdYbJj to use 3.0.0 b.) I setup a very conservative browerslist here https://github.com/mblode/marx/pull/32/files#diff-b9cfc7f2cdf78a7f4b91a753d10865a2R5 - It costs about 1-2kb extra size on the minified (but not gzipped) file. Seeing it now I should have probably went with ie >= 8 - If you have different priorities you need to change browserslist. I just wanted to make you aware.