search

mblode / marx

The classless CSS reset (perfect for Communists).
https://mblode.github.io/marx/
MIT License
1.69k stars 103 forks source link

Parameterise derived colours and update module resolution #39

Closed tuxmachine closed 5 years ago

tuxmachine commented 5 years ago

Hi Matthew,

Thanks for publishing Marx! When using it on a side project I ran into some minor inconveniences consuming it as a dependency. Sharing in case you want it.

  1. Parametise derived colours - i.e.: Button hover was still hard coded so overriding the $primary colour in my own SCSS was only partially successful
  2. Use the node-sass includePaths config to locate the sanitize dependency instead of referencing a relative path. Since a flattened dependency tree will place the dependency alongside the marx-css folder, the relative path is not reliable. Also fixes #36 assuming others configure node-sass similarly.
mblode commented 5 years ago

Thank you for fixing these issues! I had moved to the newest version of Gulp and I wasn't sure of the best way to do relative NPM includes. 👍