mblode / marx

The classless CSS reset (perfect for Communists).
https://mblode.github.io/marx/
MIT License
1.69k stars 101 forks source link

In the codepen example, the radio buttons seem wrong #54

Open julienw opened 4 years ago

julienw commented 4 years ago

STR:

=> nothing happens

Also click on Radio 1 (the button itself) and then Radio 1 => both of them are now selected.

I believe you need to change:

<label for=radio-choice-1>Radio 1:</label> <input type=radio name=radio-1 id=radio-1 tabindex=1 value=radio-1 /><br> <label for=radio-2>Radio 2:</label> <input type=radio name=radio-2 id=radio-2 tabindex=2 value=radio-2 />

to

<label for=radio-1>Radio 1:</label> <input type=radio name=radio id=radio-1 tabindex=1 value=radio-1 /><br> <label for=radio-2>Radio 2:</label> <input type=radio name=radio id=radio-2 tabindex=2 value=radio-2 />

That is, the for attribute for the first label is wrong, and the 2 names need to be the same.

Sorry I can't do a PR for the codepen demo :-)