mblode / vscode-twig-language

VS Code extension with snippets, syntax highlighting, hover, and formatting for Twig.
https://marketplace.visualstudio.com/items?itemName=mblode.twig-language
MIT License
42 stars 7 forks source link

Please make single/double quotes configurable + Quotes in README don't reflect snippets #50

Open Friksel opened 4 years ago

Friksel commented 4 years ago

First of all I love this extension. Very nice and handy snippets and I use it a lot.

Need to change the quotes after using snippets That said, everytime I use for instance the include template snippet, the snippet is using double quotes while everywhere I use (and want to use) single quotes in Twig. So need to change the quotes everytime after using the snippet. Which negates the effect of using this snippet and makes me stop using it wich is a pitty, as it's very nice to be able to use snippets for this.

The readme isn't reflecting the snippets Looking at the list of triggers in the README both single and double quotes are used, so mixed. Which doesn't only look inconsistent to me, it doesn't reflect the way the snippets actually are. For example when using the inc trigger the snippet isn't {% include 'template' %} (single quotes) as the README says, but {% include "template" %} (double quotes).

My request Please add a config setting to set the quote type to either single or double for all string-related things in Twig, so every developer is able to set his/her own preference on quotes for the snippets. I would also change the README to display the same quote-type on all strings inside snippets, using the default quote type.

Other than this, great extension. And if the quotes would be configurable that would be a great timesaver here and makes the extension even better!

Thanks in advance!