Update to v5.0.0 breaks my setup

[Z3NOX]

The automated update to v5.0.0 broke my setup and I am only able to provide a screenshot of it, that may not be of that much help. I could not get to the settings page to provide debug info, as the error message is also displayed there. Installation of Sideberry in a new Firefox profile seems to work out of the box, no error there.

I had to use the addon's version page to downgrade the app to 4.10.2, which seems to work for now.

debug info from the downgraded installation:

{
  "settings": {
    "version": "4.10.2",
    "nativeScrollbars": false,
    "selWinScreenshots": true,
    "tabsCheck": true,
    "tabsFix": "notify",
    "markWindow": false,
    "markWindowPreface": "[Sidebery] ",
    "ctxMenuNative": false,
    "autoHideCtxMenu": "none",
    "ctxMenuRenderInact": true,
    "ctxMenuIgnoreContainers": "",
    "navBarLayout": "horizontal",
    "navBarInline": true,
    "hideAddBtn": false,
    "hideSettingsBtn": false,
    "navBtnCount": true,
    "hideEmptyPanels": true,
    "navActTabsPanelLeftClickAction": "none",
    "navActBookmarksPanelLeftClickAction": "none",
    "navMidClickAction": "none",
    "navSwitchPanelsWheel": true,
    "groupLayout": "grid",
    "skipEmptyPanels": false,
    "dndTabAct": true,
    "dndTabActDelay": 750,
    "dndTabActMod": "none",
    "dndExp": "pointer",
    "dndExpDelay": 0,
    "dndExpMod": "none",
    "stateStorage": "global",
    "warnOnMultiTabClose": "any",
    "activateOnMouseUp": true,
    "activateLastTabOnPanelSwitching": true,
    "showTabRmBtn": true,
    "showTabCtx": true,
    "hideInact": false,
    "activateAfterClosing": "next",
    "activateAfterClosingPrevRule": "visible",
    "activateAfterClosingNextRule": "tree",
    "activateAfterClosingGlobal": false,
    "activateAfterClosingNoFolded": true,
    "activateAfterClosingNoDiscarded": true,
    "shiftSelAct": true,
    "askNewBookmarkPlace": false,
    "tabsRmUndoNote": true,
    "nativeHighlight": false,
    "tabsUnreadMark": false,
    "tabsReloadLimit": 5,
    "tabsReloadLimitNotif": true,
    "tabsPanelSwitchActMove": true,
    "moveNewTabPin": "start",
    "moveNewTabParent": "last_child",
    "moveNewTabParentActPanel": false,
    "moveNewTab": "end",
    "pinnedTabsPosition": "panel",
    "pinnedTabsList": false,
    "pinnedAutoGroup": false,
    "tabsTree": true,
    "groupOnOpen": true,
    "tabsTreeLimit": "none",
    "hideFoldedTabs": false,
    "autoFoldTabs": false,
    "autoFoldTabsExcept": "none",
    "autoExpandTabs": false,
    "rmChildTabs": "all",
    "tabsChildCount": true,
    "tabsLvlDots": false,
    "discardFolded": false,
    "discardFoldedDelay": 0,
    "discardFoldedDelayUnit": "sec",
    "tabsTreeBookmarks": true,
    "treeRmOutdent": "branch",
    "bookmarksPanel": true,
    "warnOnMultiBookmarkDelete": "collapsed",
    "openBookmarkNewTab": false,
    "midClickBookmark": "open_new_tab",
    "actMidClickTab": false,
    "autoCloseBookmarks": false,
    "autoRemoveOther": false,
    "highlightOpenBookmarks": false,
    "activateOpenBookmarkTab": false,
    "showBookmarkLen": false,
    "bookmarksRmUndoNote": true,
    "fontSize": "m",
    "bgNoise": true,
    "animations": true,
    "animationSpeed": "fast",
    "theme": "default",
    "style": "dark",
    "sidebarCSS": false,
    "groupCSS": false,
    "snapNotify": true,
    "snapExcludePrivate": false,
    "snapInterval": 10,
    "snapIntervalUnit": "min",
    "snapLimit": 100,
    "snapLimitUnit": "snap",
    "hScrollThroughPanels": false,
    "scrollThroughTabs": "none",
    "scrollThroughVisibleTabs": false,
    "scrollThroughTabsSkipDiscarded": false,
    "scrollThroughTabsExceptOverflow": true,
    "scrollThroughTabsCyclic": false,
    "tabDoubleClick": "new_child",
    "tabLongLeftClick": "none",
    "tabLongRightClick": "none",
    "tabsPanelLeftClickAction": "none",
    "tabsPanelDoubleClickAction": "tab",
    "tabsPanelRightClickAction": "menu",
    "tabsPanelMiddleClickAction": "tab",
    "syncName": "",
    "syncSaveSettings": false,
    "syncSaveCtxMenu": false,
    "syncSaveStyles": false,
    "syncAutoApply": false
  },
  "permissions": {
    "allUrls": true,
    "tabHide": true,
    "actualAllUrls": true,
    "actualTabHide": true
  },
  "storage": "Error: An unexpected error occurred",
  "panels": [
    {
      "type": "bookmarks",
      "id": "bookmarks",
      "cookieStoreId": "bookmarks",
      "name": 9,
      "icon": "...",
      "bookmarks": true,
      "lockedPanel": false,
      "skipOnSwitching": false
    },
    {
      "type": "default",
      "id": "firefox-private",
      "name": 7,
      "icon": "...",
      "cookieStoreId": "firefox-private",
      "lockedTabs": false,
      "lockedPanel": false,
      "skipOnSwitching": false,
      "noEmpty": false,
      "newTabCtx": "none",
      "dropTabCtx": "none",
      "moveTabCtx": "none",
      "moveTabCtxNoChild": true
    },
    {
      "type": "tabs",
      "id": "V1B4LKdzmYJc",
      "name": 11,
      "icon": "...",
      "color": "...",
      "customIconSrc": "",
      "customIcon": "",
      "lockedTabs": false,
      "lockedPanel": false,
      "skipOnSwitching": false,
      "noEmpty": false,
      "newTabCtx": "none",
      "dropTabCtx": "none",
      "moveTabCtx": "none",
      "moveTabCtxNoChild": true,
      "urlRulesActive": false,
      "urlRules": ""
    }
  ],
  "containers": [],
  "cssVars": "TypeError: can't convert undefined to object",
  "windows": [
    {
      "state": "maximized",
      "incognito": false,
      "tabsCount": 100
    },
    {
      "state": "maximized",
      "incognito": false,
      "tabsCount": 82
    }
  ],
  "bookmarks": {
    "bookmarksCount": 67,
    "foldersCount": 16,
    "separatorsCount": 0,
    "maxDepth": 3
  }
}

I there a way I can provide you with more information or a guess how to fix this update problem? Thanks!

[up-bpersons]

Also broke my setup :( , styles editor that I wrote with custom CSS no longer looks the same.

[He1my]

same issue with the upgrade, how to get back to the previous version?

[up-bpersons]

Export your current settings to the .json config file. Go to https://addons.mozilla.org/en-US/firefox/addon/sidebery/versions/ and remove the extension from Firefox. Then, go back and don't select v5.0, go to v4.10.2 and hit download file. First time I didn't remove it and just tried downloading the older version. Second time I followed the instructions above and it worked.

[mlissner]

Just got the upgrade too and I seem to have lost my settings and CSS.

[Kelendral-gh]

Same errors, same upgrade to 5.0 broke my setup. Downgrade to 4.10.2 restored a working Sideberry to my system. HOWEVER, all of tabs that were in different groups had been combined to a single panel (default), all other panels (games, system, streaming, etc empty) and all of my CSS was lost. Attempting to use the backup created during upgrade resulted in no CSS data available for import. I was able to get things mostly back to prior state (still lost some pinned tabs on my System panel and a few other tabs here and there) by using a profile backup to pull the CSS data from, and using one of the snapshots.

Very disappointed an automatic update nearly cost the loss of more than a dozen tab panels (900ish tabs), custom layout, and did cause lause of some tabs (thus breaking some trees). All while still having to downgrade back to the version I was on to even have a usable setup.

[Z3NOX]

I resolved this issue now by exporting current settings as a JSON file ("Export addon data"), removed the addon completely, installed it again in v5.0.0 and loaded the settings ("Import addon data") from the formerly exported JSON file. This seemed to have fixed it for me, but my setup was not complicated and did not contain customized CSS and only a few tab panels.

Before doing the manual update I was not able to create snapshots (ui did not respond), maybe this was also the reason for the automated update to not run smoothly through!?

[mlissner]

My custom CSS appeared in the Styles editor, but was commented out:

/* OLD CSS VARS
#root.root {--tabs-height: 22px;}
#root.root {--tabs-indent: 15px;}
#root.root {--tabs-font: .75rem sans-serif;}
#root.root {--tabs-fg: #ffffffff;}
*/

[saucoide]

is there a list of what css options were removed with this update? Some css rules dont work anymore and i cannot find any current equivalent e.g:

#root.root {--tabs-activated-border: 2px dashed #50fa7b;}

[mbnuqw]

Sorry. It's a bug of v4 - saving favicons cache and snapshots without limits can lead to broken addon storage (I can't consistently reproduce it). Unfortunately, it's not possible to fix this without losing some data. Creating partial backup and manual upgrade is the only workaround.

Also broke my setup :( , styles editor that I wrote with custom CSS no longer looks the same.

There are changes in v5 CSS selectors, so custom CSS for v4 will be broken in v5. This is the reason why the old CSS is commented on upgrade.

is there a list of what css options were removed with this update? Some css rules dont work anymore and i cannot find any current equivalent e.g:

No, there is no such list, Sidebery v5 parse CSS vars of the #root selector (e.g. https://github.com/mbnuqw/sidebery/blob/1bd348de3182798627ecc03e4cd72283606c8758/src/styles/themes/proton/sidebar/tab.styl#L3, or https://github.com/mbnuqw/sidebery/blob/1bd348de3182798627ecc03e4cd72283606c8758/src/styles/themes/proton/vars.styl#L4) and list them in the left column of the styles editor. The equivalent of the --tabs-activated-border is the --tabs-activated-shadow.

Again, sorry for data loss :pray:

[Elementari]

Again, sorry for data loss 🙏

Layperson's smartassing ahead:

I think even though many users have had some stress with the update it's really very important to "keep the spirit high", i.e. Max and team (?) have certainly been working so hard on this and it's surely rough to release sth and then causing some issues for users.

Also, let's turn this also into sth. positive, i.e. a warning that your backup and snapshot regime might need some tightening. Perhaps this experience will harden your precautions and save you from much much worse in the future.

I've turned off Sideberry auto-update now, by the way: I was wondering if FF informs the user of extension updates when auto-update is disabled? Like, in the same place where "requests new permissions" is displayed.

[mlissner]

Yeah, to be clear. Sideberry is great and I'm excited to see big breaking updates, honestly. I run a big website, and we also have an extension with 20k users. Getting all this stuff right is very hard. This is how I see it:

	Lots of features	Few features
No breakage	Best, too hard	Good, hard
Some breakage	Great, hard	Not good

So yeah, I don't mind having major updates that break things a bit if it means getting more features. Keep up the great work.