mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.26k stars 163 forks source link

`target="_blank"` links open in a new window #153

Closed starmatt closed 4 years ago

starmatt commented 4 years ago

Hello,

Steps to reproduce

Click on a link / anchor that has a target="_blank" attribute. ex:

<a href="#" target="_blank">click on me!</a>

Expected behavior

Open the link destination in a new tab / child tab.

Actual behavior

The link destination opens in a new window.

Environment info

OS: Linux Firefox: 74.0 Addon: 4.6.2

{ "settings": { "version": "4.6.2", "nativeScrollbars": false, "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "navBarLayout": "vertical", "navBarInline": false, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "list", "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": false, "activateLastTabOnPanelSwitching": true, "skipEmptyPanels": false, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": false, "activateAfterClosingNoDiscarded": false, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": true, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": true, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "xxs", "bgNoise": false, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "dark", "sidebarCSS": true, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "exp", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "syncName": "Matt's Laptop", "syncSaveSettings": true, "syncSaveCtxMenu": true, "syncSaveStyles": true, "syncAutoApply": false }, "permissions": { "allUrls": false, "tabHide": false, "actualAllUrls": false, "actualTabHide": false }, "storage": { "size": "207.8 kb", "props": { "bookmarksMenu": "226 b", "bookmarksPanelMenu": "54 b", "containers_v4": "518 b", "cssVars": "1.6 kb", "expandedBookmarks": "18 b", "favAutoCleanTime": "10 b", "favUrls": "2.6 kb", "favicons": "194.7 kb", "lastSnapTime": "13 b", "panelIndex": "1 b", "panels_v4": "378 b", "prevTabsData_v4": "1.4 kb", "profileID": "14 b", "settings": "2.4 kb", "sidebarCSS": "953 b", "snapshots_v4": "2 b", "tabsData_v4": "2 kb", "tabsMenu": "299 b", "tabsPanelMenu": "170 b" } }, "panels": [ { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false } ], "cssVars": { "bg": "#38383d", "ctx_menu_font": ".9375rem sans-serif", "tabs_height": "32px", "tabs_indent": "26px", "tabs_font": ".85rem sans-serif", "tabs_lvl_indicator_bg": "#aaaaaa" }, "sidebarCSSLen": 888, "windows": [ { "state": "normal", "incognito": false, "tabsCount": 21 } ], "tabsMenu": [ [ "undoRmTab", "mute", "reload", "bookmark" ], "separator-1", [ { "name": "Move to" }, "moveToNewWin", "moveToNewPrivWin", "moveToAnotherWin", "moveToWin" ], [ { "name": "Reopen in" }, "moveToCtr" ], "separator-2", "pin", "duplicate", "discard", "copyUrls", "separator-3", "group", "flatten", "separator-4", "clearCookies", "close" ], "bookmarksMenu": [ [ { "name": "Open in" }, "openInNewWin", "openInNewPrivWin", "openInCtr" ], "separator-5", "createBookmark", "createFolder", "createSeparator", "separator-6", "sortByName", "sortByLink", "sortByTime", "separator-7", "copyUrls", "edit", "delete" ], "bookmarks": { "bookmarksCount": 57, "foldersCount": 7, "separatorsCount": 0, "maxDepth": 3 } }
mbnuqw commented 4 years ago

Sidebery does nothing with this behavior, please check your browser settings ("Open links in tabs instead of windows")

starmatt commented 4 years ago

I am, indeed, a little dumb.

Thanks for replying and for your amazing extension!