mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.43k stars 175 forks source link

Closing last-positioned tab of a panel switches to next panel #1566

Open PWDSerialgamer07 opened 6 months ago

PWDSerialgamer07 commented 6 months ago

Steps to reproduce

Actual behavior

Sidebery jumps to the tab in the first position of the next panel

Expected behavior

Sidebery goes to the tab before the one we jsut closed

System

Windows 11

Firefox version

Floorp Version 11.11.2

Sidebery version

5.2.0

Logs

No response

nerradtreborsniktaw commented 2 months ago

Same issue observed.

System

Windows 10

Firefox version

128.0

Sidebery version

5.2.0

jpodolski commented 1 month ago

Also affecting me.

Windows 10 (22H2) Firefox Developer Edition (129.0b9) Sidebery Ver. 5.2.0.8

Perhaps illuminating to note some details on reproducing:

  1. Have a "Tab A" open and in use in "Panel A" (with some "Panel B" existing below, with open tabs)
  2. Open a new tab ("Tab B") with Ctrl+T, or by double clicking the empty space in Panel A
  3. In this "Tab B", navigate to some page that has links. Google search results work fine.
  4. Open a link on "Tab B" such that it opens in a new child tab, "Tab B2". For example, with Ctrl+Click, or by clicking a link that spawns a new tab by default (e.g., Startpage search results).
  5. Close this Tab B2, which will correctly focus Tab B.
  6. Close Tab B. This will now incorrectly focus the first tab in Panel B, rather than Tab A in Panel A as expected

Importantly, Step 6 will only fail if Step 4 is executed (opening a child tab from Tab B). If you just close Tab B after step 3 (before creating a child tab), Sidebery will focus Tab A as expected. It seems that spawning a child tab has some effect on this bug.