search

mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.48k stars 175 forks source link

"Undo close tab" missing from context menu #16

Closed mbaz closed 5 years ago

mbaz commented 5 years ago

The context menu has some very useful options, but it's missing "undo close tab", which I find essential to recover tabs closed by accident.

Sideberry v2.2.1, Firefox 66.0, Archlinux.

mbnuqw commented 5 years ago

Yep, I plan to add Undo action (for bookmarks and tabs). And I want to add ability to choose removed item[s] to restore. But I don't know yet how to implement it in UI. Since it's a general action I cannot just add it to context menu. Options are: -- add it in dashboard menu -- show button at the bottom after some tab/bookmark was closed

And I don't really like both of these options... Anyway, I need to test different variants.

mbaz commented 5 years ago

One idea would be to add a context menu option to just restore the most recently closed tab. That is what Vertical Tabs Reloaded and Tree Style Tabs do. For more fine-grained tab restoring, Firefox's "history" menu already provides a list of recently closed tabs, so you may not need to re-implement that.

Restoring deleted bookmarks is an intriguing idea. I've never needed it, but I do backup my bookmarks every once in a while...

mbnuqw commented 5 years ago

You right, I somehow forget about "Library/History" menu :smile:

What if I add customizable strip with "easy access" actions? Something like that (this is just random icons): screenshot-2019 03 26-23 12 50_1

So you can assign Undo and any action you want.

...and even more, I can allow user to completely customize context menu. hm... I need some time to test it.

mbaz commented 5 years ago

That'd be awesome.

mbaz commented 5 years ago

Seems to work -- thanks!

Jipok commented 5 years ago

On my system it looks like this: image What in my opinion is unfortunate. I thought this was the "Go back one page" button and only a search on the github questions made it clear where the "Undo close tab" is located.

mbnuqw commented 5 years ago

Hmm, you are right, icon can be counterintuitive and unfortunately there are only two ways for new user to know what it means - read tooltip on mouse hover or just click on it. If you have any suggestions of how this icon should look like, feel free to open new issue.

Jipok commented 5 years ago

Most common icons: image From flaticon Can also be found here.

image From Nerd fonts.

I think the third option (the most right) looks better.

Jipok commented 5 years ago

In TST for this action you need to install one of several external add-ons. Therefore i think the “Undo Close Tab” feature is worth mentioning in the features list or in the tips and tricks.