search

mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.43k stars 175 forks source link

[BUG] Cannot drag-and-drop outside of sidebar to open new window (FF version >= v129.0b2) #1714

Closed the-nelsonator closed 2 months ago

the-nelsonator commented 3 months ago

Steps to reproduce

Actual behavior

Does nothing

sideberydraganddrop

Expected behavior

Opens a new window with the tab

System

Windows 11

Firefox version

Open Firefox Dev Edition 129.0b2, or Firefox Nightly v130.0a1 (2024-07-12)

Sidebery version

v5.2.0

Logs

No logs at all in console.

Notes:

the-nelsonator commented 3 months ago

@rebelonion I noticed you used Dev Edition on 06/26 to demo your PR related to drag and drop: https://github.com/mbnuqw/sidebery/pull/1698.

On my machine drag and drop is not working as of Dev Edition 129.0b2 (released 7/10). Is the same true for you? Helps narrow down timeframe or if this is just due to something in my environment

sebibasti0815 commented 3 months ago

Problem exists in 129.0b3, too. "Workaround" using ff extension tabdetach and using keyboard shortcuts.

the-nelsonator commented 3 months ago

Right-click tab -> Reopen in -> New window is also a less convenient workaround

sebibasti0815 commented 3 months ago

"Move to", but, yeah 👌😂

beracira commented 3 months ago

Regarding the note: I can reproduce the issue on 

Version     128.0
Build ID    20240704121409

The ability to rearrange tabs with the sidebar is also affected.

nirurin commented 3 months ago

For me the issue (on 128) is that when I try and open a tab in a new window by dragging (or using the 'open in new window' right click menu option) the window opens fine... but sidebery is no longer open in that window. Not sure if that's related or a different bug entirely.

beracira commented 3 months ago

I found a fix (well, as least for my issue): Changing dom.events.dataTransfer.imageAsFile.enabled to true in about:config seems to fix the issue.

It looks like a regression: bugzilla link.

nirurin commented 3 months ago

Ah unfortunately that doesn't fix my issue. Even more unfortunately i haven't seen the dev respond to any bug reports for a few months.

sebibasti0815 commented 3 months ago

I found a fix (well, as least for my issue): Changing dom.events.dataTransfer.imageAsFile.enabled to true in about:config seems to fix the issue.

It looks like a regression: bugzilla link.

That doesn't fix the problem here. It's a different problem, dragging images - our problem in this case is dragging tabs.

the-nelsonator commented 3 months ago

Yeah, tried dom.events.dataTransfer.imageAsFile.enabled to true on v129.0b6 and can confirm did not fix the drag'n'drop to open in new window

Bobo1239 commented 2 months ago

I've bisected the issue to this Firefox change which makes sense since it touches the drag'n drop subsystem. The effect is that in this Sidebery line e.dataTransfer is now null instead of a DataTransfer object. (which alters our control flow) According to the MDN docs this should never happen when the event is dispatched by the browser which is the case here so I'd say this is a Firefox bug.

Unfortunately I don't have time to dive more deeply into the Firefox change so somebody else will have to do that... (I've also open a bugzilla issue for this: https://bugzilla.mozilla.org/show_bug.cgi?id=1911486)

the-nelsonator commented 2 months ago

@Bobo1239 Thank for identifying the issue (noting down that bisection tool, very cool) and reporting on Bugzilla. Looks like David Parks/handyman already got a fix in - drag and drop to open in other window works as expected in v131! (Only on Nightly for now)

Looks like, as expected since you opened a separate Bugzilla, this did not fix the issue with tabs "cloning" in the other window instead of moving.

sebibasti0815 commented 2 months ago

drag and drop to open in other window works as expected in v131! (Only on Nightly for now)

It works in 130.0b4, too. But the other issue (tabs cloning instead of moving) is there, too.