Favicon stays in light theme despite color scheme set to dark when privacy.resistFingerprinting is enabled

[k4yt3x]

Steps to reproduce

• Open Firefox in a new profile
• Install Sidebery
• Set Firefox theme to Dark in about:addons
• Set Sidebery Settings > Appearance > Color scheme to dark
• Enable privacy.resistFingerprinting in about:config
• Restart Firefox
• Open GitHub and observe its favicon color to be dark (light themed)

Actual behavior

When both Firefox and Sidebery's color themes are set explicitly set to dark, the auto-detection of color scheme mode for favicons in the sidebar still seems to read color scheme information using prefers-color-scheme or something similar, which gets blocked by privacy.resistFingerprinting. This causes certain websites' icons to be unreadable against the dark background.

Expected behavior

It is understandable that when Color scheme is set to auto light/dark or firefox that it reads the wrong information from privacy.resistFingerprinting (I've read https://github.com/mbnuqw/sidebery/issues/997). However, when Color scheme is explicitly set to dark or light, the icon color theme should follow the explicitly defined Sidebery settings to avoid showing the wrong color theme.

System

Arch Linux and Windows 11 23H2

Firefox version

130.0 (archlinux - 1.0 and Windows)

Sidebery version

5.2.0.8

Logs

Doesn't theme necessary at the moment. I can provide if it turns out to be needed.

[k4yt3x]

Thanks for the great extension btw! Can't use Firefox without it. It'll be great if this can be addressed so it's possible to use this with resist fingerprinting enabled.