mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.57k stars 176 forks source link

Add to Bookmarks: Right-clicking a collapsed GROUP bookmarks ONLY the first child TAB of the GROUP #1849

Open JohnVKRDam opened 4 weeks ago

JohnVKRDam commented 4 weeks ago

Steps to reproduce

  1. Create a GROUP
  2. Add a TAB in the GROUP (this will be the PARENT TAB)
  3. Add CHILD TABS below the PARENT TAB
  4. Collapse the GROUP
  5. Right-click the GROUP and select ADD TO BOOKMARKS from the context menu

RESULT: only the PARENT TAB is added to the Bookmarks

Now do the SAME, but instead of right-clicking the GROUP, right-click the (collapsed) PARENT TAB. Now ALL the TABS including the PARENT TAB, but not the GROUP itself, are saved to Bookmarks, with the PARENT TAB as the base Bookmark Folder. This is CORRECT, since you right-clicked the PARENT TAB.

IMPORTANT NOTE: When I DRAG the GROUP Folder to the Bookmark Button at the bottom, it DOES preserve the entire structure as expected. And it does NOT matter in that case if the GROUP is collapsed or not, it always works properly, because it drags the entire structure below the dragged GROUP/TAB.

So, with Drag & Drop working, there at least is a working alternative. It is just that Drag & Drop is not always the best way to Bookmark Group & Folder structures... For one, it is really hard to navigate to a specific folder, while all the time having to keep the left mouse button pressed.

Actual behavior

Add to Bookmarks on a GROUP does not work properly: it does NOT save the GROUP as a Bookmark Folder, and it only saves the first available TAB below the GROUP to Bookmarks. Add to Bookmarks on a PARENT TAB works as expected: it saves ALL the TABS (parent + children) to Bookmarks, with the PARENT TAB as the Bookmark Folder.

Expected behavior

When you right-click a GROUP, it should use the GROUP NAME as the base Bookmark Folder, with all children below that, in the same Folder structure as in the GROUP / TAB structure.

for example:

Consider the following structure:

Right-click on the (collapsed) GROUP should result in the following Bookmark structure:

System

Windows 11

Firefox version

131.0.3 (64-bit)

Sidebery version

5.2.0

Logs

Nothing is logged