mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.49k stars 175 forks source link

Lost snapshots #261

Open hervis73 opened 4 years ago

hervis73 commented 4 years ago

Steps to reproduce

Expected behavior

Only the erased snapshot is removed

Actual behavior

All the snapshots are gone! I am in despair since there is days of research in one of them... Is there any way to recover them?

Environment info

OS: Windows 7x64 Firefox version: 74.0.1 Addon version: 4.8.0

{ "settings": { "version": "4.8.0", "nativeScrollbars": true, "selWinScreenshots": false, "tabsCheck": true, "tabsFix": "notify", "ctxMenuNative": true, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "navBarLayout": "horizontal", "navBarInline": false, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navMidClickAction": "none", "navSwitchPanelsWheel": false, "groupLayout": "list", "dndTabAct": false, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "skipEmptyPanels": false, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": false, "activateAfterClosingNoDiscarded": false, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsReloadLimit": 5, "moveNewTabPin": "end", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": true, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": true, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "bookmarksPanel": false, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "m", "bgNoise": true, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "dark", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 15, "snapIntervalUnit": "day", "snapLimit": 10, "snapLimitUnit": "kb", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "new_after", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": true, "tabHide": true, "actualAllUrls": true, "actualTabHide": true }, "storage": { "size": "487.4 kb", "props": { "bookmarksMenu": "226 b", "bookmarksPanelMenu": "54 b", "cssVars": "1.6 kb", "disabledKeybindings": "24 b", "expandedBookmarks": "2 b", "favAutoCleanTime": "10 b", "favUrls": "30.8 kb", "favicons": "184.5 kb", "lastSnapTime": "13 b", "panelIndex": "1 b", "panels_v4": "378 b", "prevTabsData_v4": "212.6 kb", "profileID": "14 b", "settings": "2.6 kb", "snapshots_v4": "2 b", "tabsData_v4": "53.6 kb", "tabsMenu": "327 b", "tabsPanelMenu": "184 b" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true } ], "cssVars": { "tabs_height": "25px", "tabs_pinned_height": "25px", "tabs_pinned_width": "25px", "tabs_indent": "12px", "tabs_font": "1rem sans-serif" }, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 369 }, { "state": "maximized", "incognito": true, "tabsCount": 75 }, { "state": "maximized", "incognito": true, "tabsCount": 4 } ], "tabsMenu": [ [ "undoRmTab", "mute", "reload", "bookmark" ], "separator-1", [ { "name": "Move to" }, "moveToNewWin", "moveToWin", "moveToPanel" ], [ { "name": "Reopen in" }, "reopenInNewWin", "reopenInWin", "reopenInCtr" ], "separator-2", "pin", "duplicate", "discard", "copyUrls", "separator-3", "group", "flatten", "separator-4", "clearCookies", "close", "closeDescendants" ], "bookmarksMenu": [ [ { "name": "Open in" }, "openInNewWin", "openInNewPrivWin", "openInCtr" ], "separator-5", "createBookmark", "createFolder", "createSeparator", "separator-6", "sortByName", "sortByLink", "sortByTime", "separator-7", "copyUrls", "edit", "delete" ], "bookmarks": { "bookmarksCount": 32343, "foldersCount": 55, "separatorsCount": 12, "maxDepth": 3 } }
hervis73 commented 4 years ago

I forgot to add that every time I go to the snapshots viewer or create a new tab, the message "Wrong tabs position detected" appears at the bottom of the sidebar.

mbnuqw commented 4 years ago

Sorry about the data loss, the root of this problem is too small snapshots limit (10kb). I think I should ignore such limits for only one snapshot and maybe show some kind of warning.

hervis73 commented 4 years ago

Thank you for your answer!

Yeah, I suspected it would be the case, but it's still strange. since I chose a total snapshot size bigger than what I had when I set up the setting. Usually, I set up a limit of 10 snapshots, but I didn't want to overwrite an older snapshot, while doing searches in a new session, so that's why I set up temporarily this way. If there was a way to temporarily suspend automatic backup (is it snapshot interval time =0?), it would avoid this kind of situation.

Is there really no way to recover it somewhere? I tried to fiddle with a copy of the sqlite file of the addon and I found some of the lost links in the object_data table, so maybe they have been moved somewhere else (like in prevTabsData_v4 which is bigger than what I remembered) or the database is corrupted. It would explain why the message "Wrong tabs position detected" now appears each time I open a link.

I have just let my laptop in sleep mode without quitting Firefox in fear of aggravating the situation until I figure out a solution

mbnuqw commented 4 years ago

Apologize for the delay. Yes, to turn off auto-snapshots you need to remove interval time (or set it to 0).

prevTabsData_v4 is storing tabs state (with urls) of the previous run. To look into it you can open settings page, go to Storage section and click on it (or "open" button).

The "Wrong tabs position detected" notification typically appears in two cases: