mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.43k stars 174 forks source link

'Auto' theme always chooses light theme #335

Closed superuser-does closed 6 months ago

superuser-does commented 3 years ago

Steps to reproduce

Set Sidebery appearance to 'auto' Set Firefox to dark theme

Expected behavior

Sidebery follows the Firefox theme and goes dark.

Actual behavior

'Auto' seems to choose light theme for Sidebery in all instances.

Additional information

I use a program called 'Auto Dark Mode', which toggles between light and dark theme for the system. I then use the 'Default' theme in Firefox which respects the system theme and switches right on cue.

This has always worked until recently; unfortunately I didn't record the date it broke, I believe it may have been with the 84.0.2 patch.

Environment info

OS: Windows 10 Firefox version: 84.0.2 Addon version: 4.9.0

{ "settings": { "version": "4.9.0", "nativeScrollbars": false, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "hidden", "navBarInline": false, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navMidClickAction": "rm_act_tab", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "next", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": false, "activateAfterClosingNoDiscarded": false, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": true, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "top", "pinnedTabsList": false, "pinnedAutoGroup": true, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": false, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "xs", "bgNoise": false, "animations": false, "animationSpeed": "fast", "theme": "default", "style": "light", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "exp", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "Firefox on Windows 10 laptop", "syncSaveSettings": true, "syncSaveCtxMenu": true, "syncSaveStyles": true, "syncAutoApply": false }, "permissions": { "allUrls": false, "tabHide": false, "actualAllUrls": false, "actualTabHide": false }, "storage": { "size": "5.6 mb", "props": { "bookmarksMenu": "226 b", "bookmarksPanelMenu": "54 b", "containers_v4": "4.6 kb", "cssVars": "1.6 kb", "disabledKeybindings": "305 b", "expandedBookmarks": "18 b", "favAutoCleanTime": "10 b", "favUrls": "89.2 kb", "favicons": "5.5 mb", "panelIndex": "1 b", "panels_v4": "663 b", "prevTabsData_v4": "882 b", "profileID": "14 b", "settings": "2.7 kb", "tabsData_v4": "1 kb", "tabsMenu": "213 b", "tabsPanelMenu": "188 b" } }, "panels": [ { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false }, { "type": "tabs", "id": "znmYX0g1Kkjv", "name": 11, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "noEmpty": false, "newTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" } ], "containers": [ { "id": "firefox-container-3", "name": 7, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-4", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-6", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-7", "name": 7, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-8", "name": 13, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-9", "name": 7, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-10", "name": 8, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-11", "name": 9, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-58", "name": 5, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-79", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-182", "name": 5, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-433", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-542", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-544", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-911", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-941", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-943", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-944", "name": 6, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" } ], "cssVars": { "tabs_height": "43px", "tabs_count_font": "10px Arial" }, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 10 } ], "tabsMenu": [ [ "mute", "reload", "bookmark" ], "separator-1", [ { "name": "Move to" }, "moveToWin", "moveToNewWin" ], "separator-2", "pin", "duplicate", "discard", "copyUrls", "separator-3", "reopenInCtr", "group", "flatten", "separator-4", "close" ], "bookmarksMenu": [ [ { "name": "Open in" }, "openInNewWin", "openInNewPrivWin", "openInCtr" ], "separator-5", "createBookmark", "createFolder", "createSeparator", "separator-6", "sortByName", "sortByLink", "sortByTime", "separator-7", "copyUrls", "edit", "delete" ], "bookmarks": { "bookmarksCount": 6210, "foldersCount": 158, "separatorsCount": 2, "maxDepth": 4 } }
KingMob commented 2 years ago

I also have this problem, though I'm not using "Auto Dark Mode"; that's built in to FF these days.

elig0n commented 1 year ago

I find that even Dark mode not always sets a bright theme dark.

kanmeiban commented 1 year ago

When I set sideberry color scheme to auto and the OS theme is dark, the sidebar stays light. If set tofirefox it uses the theme color when the Firefox theme is Elemental – Balanced, Dark or Light , but when the Firefox theme is System theme - auto the sidebar stays light, even when the actual OS theme is dark.

Environment info

OS: Manjaro 23.0.1 Firefox: 117.0 sideberry: 5.0.0rc5

Debug info

Addon data ```json { "addonVersion": "5.0.0rc5", "firefoxVersion": "117.0", "settings": { "nativeScrollbars": true, "nativeScrollbarsThin": true, "nativeScrollbarsLeft": false, "selWinScreenshots": false, "updateSidebarTitle": true, "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "ctxMenuRenderInact": true, "ctxMenuRenderIcons": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "horizontal", "navBarInline": true, "navBarSide": "left", "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": false, "hideEmptyPanels": true, "hideDiscardedTabPanels": false, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navTabsPanelMidClickAction": "discard", "navBookmarksPanelMidClickAction": "none", "navSwitchPanelsWheel": true, "subPanelRecentlyClosedBar": true, "subPanelBookmarks": false, "subPanelHistory": true, "groupLayout": "grid", "skipEmptyPanels": true, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "dndOutside": "win", "dndActTabFromLink": true, "dndActSearchTab": true, "dndMoveTabs": false, "dndMoveBookmarks": false, "searchBarMode": "dynamic", "searchPanelSwitch": "same_type", "searchBookmarksShortcut": "", "searchHistoryShortcut": "", "warnOnMultiTabClose": "none", "activateLastTabOnPanelSwitching": true, "activateLastTabOnPanelSwitchingLoadedOnly": true, "switchPanelAfterSwitchingTab": "always", "tabRmBtn": "hover", "activateAfterClosing": "next", "activateAfterClosingStayInPanel": false, "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "askNewBookmarkPlace": true, "tabsRmUndoNote": true, "tabsUnreadMark": false, "tabsUpdateMark": "all", "tabsUpdateMarkFirst": true, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "showNewTabBtns": true, "newTabBarPosition": "after_tabs", "tabsPanelSwitchActMove": true, "tabsPanelSwitchActMoveAuto": true, "tabsUrlInTooltip": "full", "newTabCtxReopen": false, "tabWarmupOnHover": true, "tabSwitchDelay": 0, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "moveNewTabActivePin": "start", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "pinnedNoUnload": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "autoExpandTabsOnNew": false, "rmChildTabs": "folded", "tabsLvlDots": true, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "ignoreFoldedParent": false, "colorizeTabs": false, "colorizeTabsSrc": "domain", "colorizeTabsBranches": false, "colorizeTabsBranchesSrc": "url", "inheritCustomColor": true, "hideInact": false, "hideFoldedTabs": false, "hideFoldedParent": "none", "nativeHighlight": false, "warnOnMultiBookmarkDelete": "collapsed", "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": true, "activateOpenBookmarkTab": true, "showBookmarkLen": true, "bookmarksRmUndoNote": true, "loadBookmarksOnDemand": true, "pinOpenedBookmarksFolder": true, "oldBookmarksAfterSave": "ask", "loadHistoryOnDemand": true, "fontSize": "l", "animations": true, "animationSpeed": "fast", "theme": "proton", "density": "default", "colorScheme": "ff", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "snapAutoExport": false, "snapAutoExportType": "json", "snapAutoExportPath": "Sidebery/snapshot-%Y.%M.%D-%h.%m.%s", "snapMdFullTree": false, "hScrollAction": "switch_panels", "navSwitchPanelsDelay": 128, "scrollThroughTabs": "panel", "scrollThroughVisibleTabs": true, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": true, "scrollThroughTabsScrollArea": 0, "autoMenuMultiSel": true, "multipleMiddleClose": false, "longClickDelay": 500, "wheelThreshold": false, "wheelThresholdX": 10, "wheelThresholdY": 60, "tabDoubleClick": "none", "tabsSecondClickActPrev": true, "tabsSecondClickActPrevPanelOnly": false, "shiftSelAct": true, "activateOnMouseUp": true, "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabMiddleClick": "close", "tabMiddleClickCtrl": "discard", "tabMiddleClickShift": "duplicate", "tabCloseMiddleClick": "close", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "newTabMiddleClickAction": "new_child", "bookmarksLeftClickAction": "open_in_act", "bookmarksLeftClickActivate": false, "bookmarksLeftClickPos": "default", "bookmarksMidClickAction": "open_in_new", "bookmarksMidClickActivate": false, "bookmarksMidClickRemove": false, "bookmarksMidClickPos": "default", "historyLeftClickAction": "open_in_act", "historyLeftClickActivate": false, "historyLeftClickPos": "default", "historyMidClickAction": "open_in_new", "historyMidClickActivate": false, "historyMidClickPos": "default", "syncName": "Firefox Sofia", "syncSaveSettings": true, "syncSaveCtxMenu": true, "syncSaveStyles": true, "syncSaveKeybindings": false, "selectActiveTabFirst": true }, "permissions": { "allUrls": true, "webRequest": true, "webRequestBlocking": true, "proxy": false, "tabHide": true, "clipboardWrite": true, "history": true, "bookmarks": true, "downloads": false }, "storage": { "size": "133 kb", "props": { "containers": "1.33 kb", "expandedBookmarkFolders": "135 b", "favDomains": "5.26 kb", "favHashes": "1.44 kb", "favicons_01": "102 kb", "favicons_02": "2 b", "favicons_03": "2 b", "favicons_04": "2 b", "favicons_05": "2 b", "lastSnapTime": "13 b", "profileID": "14 b", "settings": "4.79 kb", "sidebar": "7.64 kb", "tabsDataCache": "10.4 kb", "ver": "10 b" } }, "sidebar": { "nav": [ "bookmarks", "firefox-default", "I4PMoErT5Aeg", "DhHaSeCgChfj", "gTFeOk7Wlpw6", "add_tp", "sp-0", "settings" ], "panels": { "bookmarks": { "type": 1, "id": "bookmarks", "name": "len: 9", "iconSVG": "icon_bookmarks", "iconIMGSrc": "", "iconIMG": "", "color": "toolbar", "lockedPanel": false, "tempMode": false, "skipOnSwitching": false, "rootId": "root________", "viewMode": "tree", "autoConvert": false, "srcPanelConfig": null }, "firefox-default": { "type": 2, "id": "firefox-default", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_tabs", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveRules": [], "moveExcludedTo": -1, "bookmarksFolderId": -1, "newTabBtns": [], "srcPanelConfig": null }, "I4PMoErT5Aeg": { "type": 2, "id": "I4PMoErT5Aeg", "name": "len: 5", "color": "toolbar", "iconSVG": "icon_man", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "firefox-container-1", "dropTabCtx": "none", "moveRules": [], "moveExcludedTo": -1, "bookmarksFolderId": -1, "newTabBtns": [], "srcPanelConfig": null }, "DhHaSeCgChfj": { "type": 2, "id": "DhHaSeCgChfj", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_book", "iconIMGSrc": "", "iconIMG": "", "lockedPanel": true, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveRules": [], "moveExcludedTo": -1, "bookmarksFolderId": -1, "newTabBtns": [], "srcPanelConfig": null }, "gTFeOk7Wlpw6": { "type": 2, "id": "gTFeOk7Wlpw6", "name": "len: 6", "color": "toolbar", "iconSVG": "icon_man", "iconIMGSrc": "len: 2902", "iconIMG": "len: 2902", "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "firefox-container-6", "dropTabCtx": "firefox-container-6", "moveRules": [ { "id": "P4iEhAjh-USp", "active": true, "containerId": "firefox-container-6", "topLvlOnly": true } ], "moveExcludedTo": -1, "bookmarksFolderId": -1, "newTabBtns": [], "srcPanelConfig": null }, "history": { "type": 4, "id": "history", "name": "len: 7", "color": "toolbar", "iconSVG": "icon_clock", "tempMode": false, "lockedPanel": false, "skipOnSwitching": false, "viewMode": "history" } } }, "containers": [ { "id": "firefox-container-1", "cookieStoreId": "firefox-container-1", "name": "8", "icon": "...", "color": "blue", "colorCode": "#37adff", "proxified": false, "proxy": null, "reopenRulesActive": false, "reopenRules": [], "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-2", "cookieStoreId": "firefox-container-2", "name": "4", "icon": "...", "color": "orange", "colorCode": "#37adff", "proxified": false, "proxy": null, "reopenRulesActive": false, "reopenRules": [], "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-3", "cookieStoreId": "firefox-container-3", "name": "7", "icon": "...", "color": "green", "colorCode": "#37adff", "proxified": false, "proxy": null, "reopenRulesActive": false, "reopenRules": [], "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-4", "cookieStoreId": "firefox-container-4", "name": "8", "icon": "...", "color": "pink", "colorCode": "#37adff", "proxified": false, "proxy": null, "reopenRulesActive": false, "reopenRules": [], "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-6", "cookieStoreId": "firefox-container-6", "name": "6", "icon": "...", "color": "blue", "colorCode": "#37adff", "proxified": false, "proxy": null, "reopenRulesActive": false, "reopenRules": [], "userAgentActive": false, "userAgent": "" } ], "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 83 } ], "bookmarks": { "bookmarksCount": 204, "foldersCount": 19, "separatorsCount": 0, "maxDepth": 3 } } ```
kanmeiban commented 1 year ago

Hmm, this behaviour is inconsistent - it seems to depend on the time of the day/night. Now it is noon and I did this:

  1. Set the Firefox theme to System theme - auto (Follow the operating system setting)
  2. In Sideberry / Settings choose either auto or firefox
  3. Firefox and sideberry change to match the OS theme automatically on changing OS setting.
mbnuqw commented 1 year ago

Hm, indeed. I can reproduce this in v5rc5. It seems checking the prefers-color-scheme: dark CSS media query is not a reliable method of detection. Will try to use -moz-dialog colors as another source for detection.

mbnuqw commented 6 months ago

Fixed in the latest version