mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.48k stars 175 forks source link

Close tabs above closes pinned tabs #342

Closed artgru closed 2 years ago

artgru commented 3 years ago

Steps to reproduce

Have some tabs pinned Have some more regular tabs Use the option close tabs above => all tabs incl. pinned are closed

Expected behavior

Similar to "Close other tabs", pinned tabs shouldn't be touched.

Actual behavior

Pinned tabs are closed with the menu "Close tabs above"

Environment info

OS:
Firefox version: 86.0b8 Addon version:

{ "settings": { "version": "4.9.1", "nativeScrollbars": true, "selWinScreenshots": false, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": false, "ctxMenuIgnoreContainers": "", "navBarLayout": "hidden", "navBarInline": true, "hideAddBtn": true, "hideSettingsBtn": false, "navBtnCount": false, "hideEmptyPanels": true, "navMidClickAction": "rm_all", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "global", "warnOnMultiTabClose": "none", "activateOnMouseUp": false, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "prev_act", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": true, "activateAfterClosingNoFolded": false, "activateAfterClosingNoDiscarded": false, "shiftSelAct": true, "askNewBookmarkPlace": true, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": false, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "moveNewTabPin": "start", "moveNewTabParent": "first_child", "moveNewTabParentActPanel": true, "moveNewTab": "after", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": true, "autoRemoveOther": false, "highlightOpenBookmarks": true, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "xl", "bgNoise": false, "animations": true, "animationSpeed": "fast", "theme": "default", "style": "dark", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "day", "hScrollThroughPanels": true, "scrollThroughTabs": "global", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "none", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "undo", "syncName": "Firefox Beta Hyper", "syncSaveSettings": true, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": true, "tabHide": true, "actualAllUrls": true, "actualTabHide": true }, "storage": { "size": "439.1 kb", "props": { "bookmarksMenu": "226 b", "bookmarksPanelMenu": "54 b", "containers_v4": "570 b", "cssVars": "1.6 kb", "disabledKeybindings": "878 b", "expandedBookmarks": "2 b", "favAutoCleanTime": "10 b", "favUrls": "18.8 kb", "favicons": "410.7 kb", "panelIndex": "1 b", "panels_v4": "780 b", "prevTabsData_v4": "1.1 kb", "profileID": "14 b", "settings": "2.7 kb", "tabsData_v4": "679 b", "tabsMenu": "361 b", "tabsPanelMenu": "184 b" } }, "panels": [ { "type": "bookmarks", "id": "bookmarks", "cookieStoreId": "bookmarks", "name": 9, "icon": "...", "bookmarks": true, "lockedPanel": false, "skipOnSwitching": false }, { "type": "default", "id": "firefox-default", "name": 7, "icon": "...", "cookieStoreId": "firefox-default", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "none", "moveTabCtxNoChild": true }, { "type": "tabs", "id": "OhCSg7bUEUZT", "name": 4, "icon": "...", "color": "...", "customIconSrc": "", "customIcon": "", "lockedTabs": false, "lockedPanel": false, "skipOnSwitching": false, "noEmpty": false, "newTabCtx": "none", "dropTabCtx": "none", "moveTabCtx": "firefox-container-9", "moveTabCtxNoChild": true, "urlRulesActive": false, "urlRules": "" } ], "containers": [ { "id": "firefox-container-9", "name": 3, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": false, "includeHosts": "", "excludeHostsActive": false, "excludeHosts": "", "userAgentActive": false, "userAgent": "" }, { "id": "firefox-container-10", "name": 7, "icon": "...", "color": "...", "proxified": false, "proxy": null, "includeHostsActive": true, "includeHosts": 21, "excludeHostsActive": true, "excludeHosts": 27, "userAgentActive": false, "userAgent": "" } ], "cssVars": { "ctx_menu_font": ".9375rem lato", "nav_btn_width": "30px", "tabs_font": "1rem lato", "tabs_count_font": ".625rem lato", "bookmarks_bookmark_font": ".875rem lato", "bookmarks_folder_font": "1rem lato" }, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 13 } ], "tabsMenu": [ "closeTabsAbove", "closeOtherTabs", "closeTabsBelow", [ "undoRmTab", "mute", "reload", "bookmark" ], "separator-1", [ { "name": "Move to" }, "moveToNewWin", "moveToWin" ], [ "reopenInCtr" ], [ { "name": "Reopen in" }, "reopenInNewWin", "reopenInWin" ], "separator-2", "pin", "duplicate", "discard", "copyUrls", "separator-3", "group", "flatten", "moveToPanel", "separator-4", "clearCookies", "close" ], "bookmarksMenu": [ [ { "name": "Open in" }, "openInNewWin", "openInNewPrivWin", "openInCtr" ], "separator-5", "createBookmark", "createFolder", "createSeparator", "separator-6", "sortByName", "sortByLink", "sortByTime", "separator-7", "copyUrls", "edit", "delete" ], "bookmarks": { "bookmarksCount": 345, "foldersCount": 36, "separatorsCount": 2, "maxDepth": 4 } }
mbnuqw commented 2 years ago

Fixed in v4.10.0