mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.27k stars 164 forks source link

[Enhancement] Option to Ctrl + Tab Skip Folded/Discarded Tabs, too #608

Open megamorphg opened 2 years ago

megamorphg commented 2 years ago

Description

Similar to the "Skip folded tabs" and "Skip discarded tabs", it would be nice to have the ability to do the optionally do the same using the standard Ctrl + (Shift) + Tab shortcuts. Chrome/Edge currently do the same with their groups (but do not skip discarded).

A possible implementation of this feature request could be:

Kookiness commented 4 months ago

I would very much like this feature too!

However, since I enable the Firefox setting to use Ctrl+Tab to swap between tabs, I would hope the "skip folded/discarded tabs" setting could also be applied to tab-switching that's done using Ctrl+PageUp/PageDown.

It also looks like this issue may be related: https://github.com/mbnuqw/sidebery/issues/1515

megamorphg commented 4 months ago

@Kookiness Currently I'm not sure if this feature is needed anymore or not: when using the Quickbinding to go to the next/previous history item, it already skips the unloaded tabs. This is great and gives me two ways to switch tabs:

So I think maybe we can close this one.

Kookiness commented 3 months ago

@megamorphg Mine does not skip folded tabs when I press Ctrl+PgUp/PgDn. Could you describe how you are able to accomplish this, or does yours only skip the unloaded tabs?

megamorphg commented 3 months ago

@Kookiness use the following two keybindings: image

Kookiness commented 3 months ago

Thank you! Much appreciated, I didn't know about that. :)

It still unfortunately means assigning additional shortcuts for a function that essentially already has shortcut keys.

I still feel this feature should not need to be duplicated across two different pairs of shortcut keys for the sake of being able to skip folded tabs.

megamorphg commented 3 months ago

I still feel this feature should not need to be duplicated across two different pairs of shortcut keys for the sake of being able to skip folded tabs.

Firefox does not let you override native shortcut keys. Otherwise you could override the native shortcut. Anyway, as mentioned, I find it useful to have two sets of shortcuts, one to ignore unloaded tabs, and another to not ignore unloaded tabs. See the silver lining. :)

Kookiness commented 3 months ago

Ahh, okay, I figured it would be a case of modifying the function of that shortcut, rather than overriding it. Wasn't quite sure how that would work. Thanks for the clarification! I didn't realise it was impossible.

Yes, that's a good point about having the option for separate shortcuts. I just need to find a way to bind a shortcut that fits my workflow. Thanks! :)

megamorphg commented 3 months ago

I just need to find a way to bind a shortcut that fits my workflow. Thanks! :)

You can use Autohotkey or any other keyboard mapping software (like in PowerToys) to point whatever buttons you press for the native Firefox shortcut to trigger the keybinding instead.

cdavie-artium commented 1 month ago

I understand that Firefox does not allow overriding native shortcuts, but somehow this is still possible because Tree Style Tabs does it. I would also really like to be able to use the default Firefox Ctrl+Tab to cycle through unhidden tabs, like I used to be able to with TST.

(I am a long-time Tree Style Tab user, just starting to use Sidebery, due to performance issues with TST.)