on snapshot restore, fetch favicons

mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.

MIT License

3.06k stars 159 forks source link

on snapshot restore, fetch favicons #680

Open br4nnigan opened 2 years ago

br4nnigan commented 2 years ago

Description

I think the title says it, when restoring a snapshot the icons arent fetched. You have to load all tabs completely and manually.

br4nnigan commented 2 years ago

Also, and this is why I had to restore a snapshot, apparently previous session isn't restored upon startup? Doesnt matter whether I select session storage or global storage

e: this only happens occasionally, I will keep watching

albino1 commented 1 year ago

I'd like to +1 this. Loading hundreds of unloaded tabs that are blank without favicons is pretty wonky.

Interestingly, they have favicons in the Sidebery vertical list, so they should exist, but there's no favicons in the normal Firefox horizontal tab bar. This only happens when restoring from a Sidebery Snapshot, which is the preferred way to restore tabs as otherwise I lose my panels if I just use the normal Firefox restore.

This is in v5.0.0b25 with Firefox 104.0.1. Thanks!

megamorphg commented 1 year ago

For me, ome favicons are correct but most are incorrect until reloading them. Doing this in mass can crash a system. Maybe can have some sort of favicon refresh action? Not sure how this would be implemented.