mbnuqw / sidebery

Firefox extension for managing tabs and bookmarks in sidebar.
MIT License
3.43k stars 174 forks source link

Tab style change when enabling about:config resistFingerprinting #997

Closed Xuerian closed 6 months ago

Xuerian commented 1 year ago

Steps to reproduce

Expected behavior

No change

Actual behavior

Tab styling changes

Debug info

Addon data ```json General Context menu Use comma-separated list of contaianers names or /regexp/ Navigation bar Group page Containers Panels Drag and Drop Tabs - global storage - fast, but inaccurate in rare cases. - session storage - more strict, but slower. (Warning: Tabs data will be removed along with Browser Session) Note: If you have issues with incorrectly restored tabs, try to reopen sidebar and change this option. Position of new tab Pinned tabs Tabs tree Bookmarks Appearance Notes: - To apply theme color to Sidebery buttons in browser interface set "svg.context-properties.content.enabled" to "true" in about:config page. Mouse Keybindings Open/Close sidebar panel F1 off on Switch to next panel Alt+Period off on Switch to previous panel Alt+Comma off on Open new tab in active panel Ctrl+Space off on Open new tab after active tab Ctrl+Shift+Space off on Open new tab as the first child of active tab --- off on Open new tab as the last child of active tab --- off on Remove selected items or active tab --- off on Select all --- off on Select up Alt+Up off on Select down Alt+Down off on Select range up Alt+Shift+Up off on Select range down Alt+Shift+Down off on Activate selection Alt+Space off on Reset selection Alt+R off on Open menu --- off on Fold selected branch --- off on Expand selected branch --- off on Fold inactive branches --- off on Active tabs history: Back --- off on Active tabs history: Next --- off on Active tabs history of panel: Back --- off on Active tabs history of panel: Next --- off on Move selected tabs to the active tab --- off on Move tabs up --- off on Move tabs down --- off on Increase tab's tree level (indent) --- off on Decrease tab's tree level (outdent) --- off on Create snapshot --- off on Switch to first panel --- off on Switch to second panel --- off on Switch to third panel --- off on Switch to fourth panel --- off on Switch to fifth panel --- off on Switch to sixth panel --- off on Switch to seventh panel --- off on Switch to eighth panel --- off on Switch to ninth panel --- off on Switch to tenth panel --- off on Permissions Required for: - Cleaning cookies - Proxy and URL rules of containers - Screenshots for the group page and windows selection panel - Changing the User-Agent per container Required for: - Hiding tabs in inactive panels - Hiding folded tabs Required for: - Copying URLs of tabs/bookmarks through context menu Required for: - Changing the User-Agent per container Required for: - Per-container proxy Snapshots Storage (~662 kb) favicons ~583.2 kb prevTabsData_v4 ~31.3 kb tabsData_v4 ~28.3 kb favUrls ~14.2 kb settings ~2.8 kb cssVars ~1.7 kb disabledKeybindings ~33 b profileID ~14 b favAutoCleanTime ~10 b panelIndex ~1 b Sync (~2 b) Help Note: Updating tabs may cause them to be rearranged OS: win Firefox: 112.0 Addon: 4.10.2 { "settings": { "version": "4.10.2", "nativeScrollbars": false, "selWinScreenshots": true, "tabsCheck": true, "tabsFix": "notify", "markWindow": false, "markWindowPreface": "[Sidebery] ", "ctxMenuNative": false, "autoHideCtxMenu": "none", "ctxMenuRenderInact": true, "ctxMenuIgnoreContainers": "", "navBarLayout": "hidden", "navBarInline": false, "hideAddBtn": false, "hideSettingsBtn": false, "navBtnCount": true, "hideEmptyPanels": true, "navActTabsPanelLeftClickAction": "none", "navActBookmarksPanelLeftClickAction": "none", "navMidClickAction": "none", "navSwitchPanelsWheel": true, "groupLayout": "grid", "skipEmptyPanels": false, "dndTabAct": true, "dndTabActDelay": 750, "dndTabActMod": "none", "dndExp": "pointer", "dndExpDelay": 0, "dndExpMod": "none", "stateStorage": "session", "warnOnMultiTabClose": "collapsed", "activateOnMouseUp": true, "activateLastTabOnPanelSwitching": true, "showTabRmBtn": true, "showTabCtx": true, "hideInact": false, "activateAfterClosing": "none", "activateAfterClosingPrevRule": "visible", "activateAfterClosingNextRule": "tree", "activateAfterClosingGlobal": false, "activateAfterClosingNoFolded": true, "activateAfterClosingNoDiscarded": true, "shiftSelAct": true, "askNewBookmarkPlace": false, "tabsRmUndoNote": true, "nativeHighlight": false, "tabsUnreadMark": true, "tabsReloadLimit": 5, "tabsReloadLimitNotif": true, "tabsPanelSwitchActMove": true, "moveNewTabPin": "start", "moveNewTabParent": "last_child", "moveNewTabParentActPanel": false, "moveNewTab": "end", "pinnedTabsPosition": "panel", "pinnedTabsList": false, "pinnedAutoGroup": false, "tabsTree": true, "groupOnOpen": true, "tabsTreeLimit": "none", "hideFoldedTabs": false, "autoFoldTabs": false, "autoFoldTabsExcept": "none", "autoExpandTabs": false, "rmChildTabs": "none", "tabsChildCount": true, "tabsLvlDots": false, "discardFolded": false, "discardFoldedDelay": 0, "discardFoldedDelayUnit": "sec", "tabsTreeBookmarks": true, "treeRmOutdent": "branch", "bookmarksPanel": true, "warnOnMultiBookmarkDelete": "collapsed", "openBookmarkNewTab": false, "midClickBookmark": "open_new_tab", "actMidClickTab": false, "autoCloseBookmarks": false, "autoRemoveOther": false, "highlightOpenBookmarks": false, "activateOpenBookmarkTab": false, "showBookmarkLen": false, "bookmarksRmUndoNote": true, "fontSize": "xxs", "bgNoise": false, "animations": false, "animationSpeed": "fast", "theme": "tactile", "style": "auto", "sidebarCSS": false, "groupCSS": false, "snapNotify": true, "snapExcludePrivate": false, "snapInterval": 0, "snapIntervalUnit": "min", "snapLimit": 0, "snapLimitUnit": "snap", "hScrollThroughPanels": false, "scrollThroughTabs": "none", "scrollThroughVisibleTabs": false, "scrollThroughTabsSkipDiscarded": false, "scrollThroughTabsExceptOverflow": true, "scrollThroughTabsCyclic": false, "tabDoubleClick": "none", "tabLongLeftClick": "none", "tabLongRightClick": "none", "tabsPanelLeftClickAction": "none", "tabsPanelDoubleClickAction": "tab", "tabsPanelRightClickAction": "menu", "tabsPanelMiddleClickAction": "tab", "syncName": "", "syncSaveSettings": false, "syncSaveCtxMenu": false, "syncSaveStyles": false, "syncAutoApply": false }, "permissions": { "allUrls": false, "tabHide": false, "actualAllUrls": false, "actualTabHide": false }, "storage": { "size": "662.1 kb", "props": { "cssVars": "1.7 kb", "disabledKeybindings": "33 b", "favAutoCleanTime": "10 b", "favUrls": "14.2 kb", "favicons": "583.2 kb", "panelIndex": "1 b", "prevTabsData_v4": "31.3 kb", "profileID": "14 b", "settings": "2.8 kb", "tabsData_v4": "28.5 kb" } }, "panels": "TypeError: t is undefined", "containers": [], "cssVars": { "bg": "#030303ff", "tabs_bg_hover": "#4a4a4aff", "tabs_activated_bg": "#2c3636ff", "tabs_activated_fg": "#9fe3aaff" }, "windows": [ { "state": "maximized", "incognito": false, "tabsCount": 111 }, { "state": "maximized", "incognito": false, "tabsCount": 15 }, { "state": "minimized", "incognito": false, "tabsCount": 23 }, { "state": "minimized", "incognito": false, "tabsCount": 8 }, { "state": "minimized", "incognito": false, "tabsCount": 8 }, { "state": "minimized", "incognito": false, "tabsCount": 26 }, { "state": "minimized", "incognito": false, "tabsCount": 2 }, { "state": "minimized", "incognito": false, "tabsCount": 27 }, { "state": "maximized", "incognito": false, "tabsCount": 24 }, { "state": "maximized", "incognito": false, "tabsCount": 3 } ], "bookmarks": { "bookmarksCount": 2944, "foldersCount": 70, "separatorsCount": 1, "maxDepth": 4 } } ```
Logs ``` Console empty ```
pe1uca commented 1 year ago

I also realized this and disabled privacy.resistFingerprinting since I was annoyed by this issue.
But seems this is intended behavior.

Based on this mozilla article this config disables the reporting of some custom settings of the user, based on the comment "Your timezone is reported to be UTC", so your personal/local settings are reported as the default ones.

I haven't fully looked into this, my guess is the prefers-color-scheme is also masked and JS won't be able to update accordingly.
You can fix this updating "Color scheme" in settings/settings.html#settings_appearance from "auto" to the one you want.

(This can also be seen here in github, go to https://github.com/settings/appearance and "Sync with system" won't work properly with resistFingerprinting enabled, you need to set "Single theme")

mbnuqw commented 6 months ago

Expected behavior with resistFingerprinting enabled, use static color scheme in Sidebery settings > Appearance