mbod / comm318_F21_Project_Group2

0 stars 0 forks source link

Ready to submit #3

Open chrchien opened 2 years ago

chrchien commented 2 years ago

Hi Matt - just wanted to let you know that we're ready for submission. Thank you!

mbod commented 2 years ago

Ok latest versions of files should be on repo

if you can both check and then confirm you are happy for project to be considered finished

srinidhipr commented 2 years ago

Hi! For some reason, none of the images we have added (some of which are graphs needed in the story) are showing up on Github, despite showing up in JupyterHub. The pictures have correctly uploaded in the img_datastory folder but don't render in the final data story. As of now we are running code along the lines of "." I'll try and do some research to see why this might be, but in the meantime I was wondering if you've seen this before / know how to fix it.

mbod commented 2 years ago

That is a weird one - I tried a few things to see if changing from markdown syntax for image to html helped...

But in the end it was a weird issues to do with the repo visibility - I set it public and then it displayed. Now it is back to private and your image is visible in the final data notebook (can you confirm?)

One of those strange bug/issues that really don't make much sense!

srinidhipr commented 2 years ago

Hmm, now for me, it shows up as a broken image icon, as opposed to the picture itself. Perhaps it's just my computer settings?

screenshot below --

Screen Shot 2021-12-25 at 3 41 22 PM

mbod commented 2 years ago

try a refresh of page a few times

image

srinidhipr commented 2 years ago

Ah, it works for me now, thanks! I'm ready to confirm submission!

mbod commented 2 years ago

with making the repo public needed to remove the client id and secret key from your spotify code

was it just the four notebooks in the data_analysis/Data Collection folder that used them?

don't want anyone to be able to look into the repo and steal your ids

srinidhipr commented 2 years ago

yes! It was just those four notebooks. Thanks for bringing that up!