mbof / hxsync

MIT License
4 stars 0 forks source link

Add support for HX870 (issue #4) #20

Closed mbof closed 6 months ago

mbof commented 6 months ago

This is intended to add support for HX870 (issue #4)

I have not tested this.

The device IDs are sourced from https://github.com/cr/hx870/blob/master/hxtool/device.py

The waypoint memory locations are sourced from https://pc5e.nl/info/standard-horizon-hx890e-marine-handheld

The waypoints in the 890E DAT file are identically formatted as in the 870, but there are now 250 of them and they are listed from 0xD700 to 0xF63F instead of 0x4300 to 0x5BFF in the DAT file.

johannessen commented 6 months ago

Based on a brief initial test, reading data seems to work, aside from #21. Haven’t tried writing waypoints back to the device.

How do you handle the deletion of waypoints that are referenced from the waypoint history or from routes?

mbof commented 6 months ago

Thanks for testing!!

How do you handle the deletion of waypoints that are referenced from the waypoint history or from routes?

It's not handled at all right now... Currently waypoint deletion just deletes from the waypoint directory, and I haven't tested what it does to routes that contain this point. I opened issue #23 for this.

Issue #21 seems independent, so I'll merge this in for now and close #4.

johannessen commented 6 months ago

Briefly tested writing as well today. Aside from #26 and #27, it seems to work fine. Very cool! 😎