Figure out what should happen when deleting a waypoint referenced in a route

mbof / hxsync

MIT License

4 stars 0 forks source link

Figure out what should happen when deleting a waypoint referenced in a route #23

Closed mbof closed 5 months ago

mbof commented 6 months ago

Currently, when a waypoint is referenced in a route or in the waypoint history, we don't do anything special in the waypoint editor. In particular, if it's deleted, I'm not sure what happens currently.

Ideally, I suppose that the user could see a warning with the list of routes that contain it, and a few options:

Delete the waypoint, and skip it in any routes that contain it
Delete the waypoint, and delete any routes that contain it
Don't delete the waypoint

mbof commented 6 months ago

Manually tested: after deleting a waypoint referenced in a route, the whole route shows up as empty on the device.

mbof commented 5 months ago

The on-device route UI gets pretty funky with dangling waypoint references, so this isn't a bad idea to fix. The implemented fix is to do what YCE seems to do: skip the waypoint in any routes that contain it.